xlog_runtime/executor/

wcoj_dispatch.rs

//! WCOJ triangle dispatch runtime hook.
//!
//! Wires the GPU WCOJ kernels into the executor's per-rule loop.
//! Production callers leave `RuntimeConfig::default()` and use
//! the stats-backed dispatch model.
//!
//! Override knobs (config + env, highest precedence first):
//!
//!   1. **Force-WCOJ** — `wcoj_triangle_dispatch=Some(true)` /
//!      [`ENV_USE_WCOJ_TRIANGLE_U32`]. Bypasses stats decision.
//!   2. **Explicit force-off** —
//!      `wcoj_triangle_dispatch=Some(false)`. Used by bench
//!      `Mode::Off` cells and any test that wants binary-join.
//!   3. **Default**: stats-backed dispatch model.
//!
//! ## Recognized RIR Shape
//!
//! The hook now consumes [`RirNode::MultiWayJoin`], produced by
//! [`xlog_logic::promote::promote_multiway`] after the optimizer
//! pass in [`xlog_logic::Compiler::compile_program_with_stats_snapshot`].
//! The promoter rewrites the canonical lowered+optimized triangle
//! tree to a `MultiWayJoin` whose structure encodes the same
//! semantic invariants as the earlier strict tree-pattern matcher:
//!
//! * `inputs` is a 3-element vec of `Scan` nodes in WCOJ slot
//!   order `[xy, yz, xz]`.
//! * `slot_vars` is exactly `[[Some(0), Some(1)], [Some(1), Some(2)],
//!   [Some(0), Some(2)]]` — variable-class ids for X, Y, Z.
//! * `output_columns` is exactly
//!   `[Column(0), Column(1), Column(3)]` (matching the certified
//!   GPU kernel's (X, Y, Z) emit order).
//! * `fallback` is the post-optimizer binary-join tree, executed
//!   verbatim when this hook declines.
//!
//! Anything else (rotated/computed projection, non-canonical
//! slot_vars, non-Scan inputs, recursive SCC, missing input
//! buffers, unsupported scalar types, mixed-width slots, or no
//! runtime-backed memory manager) returns `Ok(None)` and the
//! caller takes the embedded `fallback` path.
//!
//! Width branching: 4-byte (U32 / Symbol) inputs go to
//! `wcoj_layout_u32_recorded` + `wcoj_triangle_hg_u32_recorded`;
//! 8-byte (U64) inputs go to the `_u64_recorded` siblings. All
//! three slots must share a width.
//!
//! ## Failure handling
//!
//! Per dispatch contract: "failure in helper must not corrupt store
//! state." If the WCOJ pipeline (layout construction or kernel
//! launch) returns an error, the hook converts it to `Ok(None)`
//! and the caller falls back to the existing path. The store is
//! never partially mutated; the dispatch hook only writes when the
//! full pipeline succeeds, and the writeback is the caller's
//! responsibility.
//!
//! ## Hook surface
//!
//! The dispatcher exposes two entry points per shape:
//!
//! * `try_dispatch_wcoj_*(rule)` — keyed on `&CompiledRule`,
//!   used by the non-recursive arm in `execute_stratum_impl`.
//! * `try_dispatch_wcoj_*_on_body(body)` — keyed on `&RirNode`,
//!   used by the recursive arm via
//!   `Executor::execute_wcoj_or_fallback_node` on both seeding
//!   and per-variant evaluation. The promoter gates recursive bodies
//!   by per-rule recursive-scan count: a single recursive scan can
//!   promote, while two or more stay on the binary-join path.
//!
//! ## Out of Scope
//!
//! * Additional cost-model expansion.
//! * Mixed-width admission (a triangle with both U32 and U64
//!   slots stays on the binary-join path).
//! * Multi-recursive WCOJ with two or more in-SCC body scans.

use std::collections::HashSet;

use xlog_core::{resolve_bool, RelId, Result, ScalarType, Schema};
use xlog_cuda::device_runtime::StreamId;
use xlog_cuda::provider::NESTED_LOOP_TOTAL_THRESHOLD;
use xlog_cuda::wcoj_metadata::{Wcoj4CycleRootAggValue, WcojRootAggValue};
use xlog_cuda::CudaBuffer;
use xlog_cuda::JoinType as CudaJoinType;
use xlog_ir::{
    rir::{KCliqueVariableOrder, MultiwayPlan, ProjectExpr, VariableOrder},
    CompiledRule, RirNode,
};

use super::Executor;

#[cfg(feature = "wcoj-phase-timing")]
use std::time::Instant;

/// Environment variable controlling forced WCOJ triangle dispatch.
pub(super) const ENV_USE_WCOJ_TRIANGLE_U32: &str = "XLOG_USE_WCOJ_TRIANGLE_U32";

/// Environment variable that disables WCOJ triangle dispatch before all other gates.
pub(super) const ENV_DISABLE_WCOJ_TRIANGLE: &str = "XLOG_DISABLE_WCOJ_TRIANGLE";

/// Resolve forced triangle dispatch as explicit config, environment, then off.
pub(super) fn wcoj_gate_enabled(config_override: Option<bool>) -> Result<bool> {
    resolve_bool(config_override, ENV_USE_WCOJ_TRIANGLE_U32, false)
}

/// Resolve the triangle kill switch as explicit config, environment, then off.
pub(super) fn wcoj_triangle_disabled(config_override: Option<bool>) -> Result<bool> {
    resolve_bool(config_override, ENV_DISABLE_WCOJ_TRIANGLE, false)
}

pub(super) const ENV_WCOJ_BLOCK_WORK_UNIT: &str = "XLOG_WCOJ_BLOCK_WORK_UNIT";
pub(super) const WCOJ_BLOCK_WORK_UNIT_DEFAULT: u32 = 1024;
pub(super) const WCOJ_BLOCK_WORK_UNIT_MAX: u32 = 8192;

pub(super) fn wcoj_block_work_unit() -> u32 {
    match std::env::var(ENV_WCOJ_BLOCK_WORK_UNIT) {
        Ok(raw) => match raw.trim().parse::<u32>() {
            Ok(v @ 1..=WCOJ_BLOCK_WORK_UNIT_MAX) => v,
            Ok(v) => {
                eprintln!(
                    "warning: {ENV_WCOJ_BLOCK_WORK_UNIT}={v} is outside 1..={WCOJ_BLOCK_WORK_UNIT_MAX}; \
                     using {WCOJ_BLOCK_WORK_UNIT_DEFAULT}"
                );
                WCOJ_BLOCK_WORK_UNIT_DEFAULT
            }
            Err(_) => {
                eprintln!(
                    "warning: {ENV_WCOJ_BLOCK_WORK_UNIT}={raw:?} is not a u32; \
                     using {WCOJ_BLOCK_WORK_UNIT_DEFAULT}"
                );
                WCOJ_BLOCK_WORK_UNIT_DEFAULT
            }
        },
        Err(_) => WCOJ_BLOCK_WORK_UNIT_DEFAULT,
    }
}

pub(super) fn wcoj_adaptive_enabled(config_override: Option<bool>) -> bool {
    config_override.unwrap_or(true)
}

/// Kill switch for the aggregate-fused group-by-root count dispatch.
/// Default ON (fusion enabled); set to `1`/`true` to force every
/// GroupBy-over-triangle through the materialize+groupby path.
pub(super) const ENV_DISABLE_WCOJ_GROUPBY_FUSION: &str = "XLOG_DISABLE_WCOJ_GROUPBY_FUSION";

pub(super) fn wcoj_groupby_fusion_disabled() -> Result<bool> {
    resolve_bool(None, ENV_DISABLE_WCOJ_GROUPBY_FUSION, false)
}

/// Kill switch for the generalized Free Join dispatch. Default ON
/// (dispatch enabled); set to `1`/`true` to force every general
/// multiway body through the embedded binary fallback.
pub(super) const ENV_DISABLE_FREE_JOIN: &str = "XLOG_DISABLE_FREE_JOIN";

pub(super) fn free_join_disabled() -> Result<bool> {
    resolve_bool(None, ENV_DISABLE_FREE_JOIN, false)
}

/// Kill switch for the factorized recursive-delta dispatch. Default
/// ON (dispatch enabled); set to `1`/`true` to force every recursive
/// delta step through the legacy hash-join -> diff path.
pub(super) const ENV_DISABLE_FACTORIZED_DELTA: &str = "XLOG_DISABLE_FACTORIZED_DELTA";

pub(super) fn factorized_delta_disabled() -> Result<bool> {
    resolve_bool(None, ENV_DISABLE_FACTORIZED_DELTA, false)
}

/// Default dense-domain dispatch cap (bitmap 32 MiB + counts 128 MiB).
/// `XLOG_FACTORIZED_DELTA_MAX_DOMAIN` raises it up to the provider hard
/// bound `FJ_DELTA_MAX_DOMAIN` (2^16).
const FACTORIZED_DELTA_DEFAULT_MAX_DOMAIN: u32 = 1 << 14;

fn factorized_delta_max_domain() -> u32 {
    std::env::var("XLOG_FACTORIZED_DELTA_MAX_DOMAIN")
        .ok()
        .and_then(|v| v.parse::<u32>().ok())
        .unwrap_or(FACTORIZED_DELTA_DEFAULT_MAX_DOMAIN)
        .min(xlog_cuda::provider::FJ_DELTA_MAX_DOMAIN)
}

/// Byte ceiling for the sparse route's conservative hash table; over it
/// the sparse entry declines to the legacy path. Defaults to half the
/// device budget; `XLOG_FACTORIZED_DELTA_MAX_TABLE_BYTES` overrides it
/// (tuning + tests forcing the decline boundary).
fn factorized_delta_max_table_bytes(budget_bytes: u64) -> u64 {
    std::env::var("XLOG_FACTORIZED_DELTA_MAX_TABLE_BYTES")
        .ok()
        .and_then(|v| v.parse::<u64>().ok())
        .unwrap_or(budget_bytes / 2)
}

/// Per-iteration work-floor divisor: dispatch only when the estimated
/// candidate work is at least `n_words / divisor`, protecting sparse /
/// long-chain fixpoints from the bitmap popcount+scan floor.
fn factorized_delta_work_divisor() -> u64 {
    std::env::var("XLOG_FACTORIZED_DELTA_WORK_DIVISOR")
        .ok()
        .and_then(|v| v.parse::<u64>().ok())
        .filter(|&v| v >= 1)
        .unwrap_or(8)
}

/// Per-fixpoint dispatch context for the factorized recursive delta.
/// Owned by one `execute_recursive_scc` call: caches the dense-domain
/// bound per (head, static rel) — `None` records a for-this-fixpoint
/// decline — and layout-normalized static buffers for non-recursive
/// (EDB) static sides.
#[derive(Default)]
pub(super) struct FactorizedDeltaCtx {
    domain_by_key: std::collections::HashMap<(String, RelId), Option<u32>>,
    static_norm_cache: std::collections::HashMap<(RelId, usize), CudaBuffer>,
}

/// Diagnostics gate for WCOJ pipeline errors. By default a layout/kernel
/// error declines to the binary-join fallback (the store is never partially
/// mutated) but is **counted** (`Executor::wcoj_error_decline_count`) and
/// logged to stderr, so a regressed kernel cannot silently disappear from
/// production dispatch behind the silent-fallback contract. Set
/// `XLOG_WCOJ_STRICT=1` to propagate the error instead (diagnostic mode).
pub(super) const ENV_WCOJ_STRICT: &str = "XLOG_WCOJ_STRICT";

pub(super) fn wcoj_strict_errors_enabled() -> Result<bool> {
    resolve_bool(None, ENV_WCOJ_STRICT, false)
}

/// Convert a WCOJ pipeline error into a counted, logged decline
/// (`Ok(None)` — caller falls back to the binary-join path), or propagate
/// it when [`ENV_WCOJ_STRICT`] is set. Structural declines (gate off,
/// shape mismatch, missing buffer) stay silent and do NOT go through here;
/// this seam is only for real layout/kernel failures.
pub(super) fn wcoj_decline_on_error(
    counter: &mut u64,
    stage: &str,
    err: xlog_core::XlogError,
) -> Result<Option<CudaBuffer>> {
    *counter += 1;
    if wcoj_strict_errors_enabled()? {
        return Err(err);
    }
    eprintln!("warning: WCOJ {stage} pipeline error; declining to binary-join fallback: {err}");
    Ok(None)
}

/// Chain dispatcher gate. Default ON after profiler traces showed
/// chain-shaped rules dominated evaluation time; `XLOG_WCOJ_CHAIN_ENABLE=0`
/// or `false` disables the route for A/B measurements.
pub(super) const ENV_WCOJ_CHAIN_ENABLE: &str = "XLOG_WCOJ_CHAIN_ENABLE";

pub(super) fn chain_dispatch_enabled() -> Result<bool> {
    resolve_bool(None, ENV_WCOJ_CHAIN_ENABLE, true)
}

// -----------------------------------------------------------------
// 4-cycle dispatch gates.
//
// Width-neutral env naming: `XLOG_USE_WCOJ_4CYCLE` controls the
// force gate across u32 / u64 / Symbol. Triangle's `_U32` suffix is
// historical debt; we do NOT propagate that pattern to 4-cycle.
//
// Adaptive resolution differs from triangle: 4-cycle is **opt-in by
// default**. Unset env + `None` config → `false`. Default-on is
// gated on bench evidence and lives in a separate follow-up decision.
// -----------------------------------------------------------------

/// Force-gate env. `"1"` / case-insensitive `"true"` → ON.
pub(super) const ENV_USE_WCOJ_4CYCLE: &str = "XLOG_USE_WCOJ_4CYCLE";

/// Adaptive opt-in env. Default off for explicit-only dispatch.
pub(super) const ENV_USE_WCOJ_4CYCLE_ADAPTIVE: &str = "XLOG_USE_WCOJ_4CYCLE_ADAPTIVE";

/// Kill switch env.
pub(super) const ENV_DISABLE_WCOJ_4CYCLE: &str = "XLOG_DISABLE_WCOJ_4CYCLE";

/// Resolve the 4-cycle force gate (config override > env > false).
pub(super) fn wcoj_4cycle_gate_enabled(config_override: Option<bool>) -> Result<bool> {
    resolve_bool(config_override, ENV_USE_WCOJ_4CYCLE, false)
}

/// Resolve the 4-cycle adaptive opt-in. Precedence:
///   * `config_override = Some(b)` → `b`.
///   * `XLOG_USE_WCOJ_4CYCLE_ADAPTIVE=1` → `true`.
///   * Anything else (including unset) → `false`.
///
/// **Differs from triangle**: triangle defaults adaptive to `true`
/// when env is unset (default-on flip after baseline evidence).
/// 4-cycle defaults to `false` until its own baseline evidence
/// supports a default-on flip in a follow-up slice.
pub(super) fn wcoj_4cycle_adaptive_enabled(config_override: Option<bool>) -> Result<bool> {
    resolve_bool(config_override, ENV_USE_WCOJ_4CYCLE_ADAPTIVE, false)
}

/// Resolve the 4-cycle kill switch (config > env > false).
pub(super) fn wcoj_4cycle_disabled(config_override: Option<bool>) -> Result<bool> {
    resolve_bool(config_override, ENV_DISABLE_WCOJ_4CYCLE, false)
}

/// Resolved dispatch mode after consulting both gates.
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
enum DispatchMode {
    Force,
    CostModel,
}

/// Two rel IDs and key positions extracted from a matched chain RIR.
/// Inputs are in the promoter's left/right order.
pub(super) struct ChainRirMatch {
    pub rel_left: RelId,
    pub rel_right: RelId,
    pub left_key: usize,
    pub right_key: usize,
    pub output_columns: Vec<ProjectExpr>,
}

/// ChainJoin production matcher. The chain shape is encoded as a
/// first-class `ChainJoin`; malformed non-scan inputs decline dispatch
/// and execute the captured fallback.
pub(super) fn match_chain_join(body: &RirNode) -> Option<ChainRirMatch> {
    let RirNode::ChainJoin {
        left,
        right,
        left_key,
        right_key,
        output_columns,
        ..
    } = body
    else {
        return None;
    };
    if *left_key >= 2 || *right_key >= 2 {
        return None;
    }
    let rel_left = scan_rel(left)?;
    let rel_right = scan_rel(right)?;
    Some(ChainRirMatch {
        rel_left,
        rel_right,
        left_key: *left_key,
        right_key: *right_key,
        output_columns: output_columns.clone(),
    })
}

fn fallback_scan_filter_equivalents(node: &RirNode) -> (u64, u64) {
    match node {
        RirNode::Unit | RirNode::TensorMaskedJoin { .. } => (0, 0),
        RirNode::Scan { .. } => (1, 0),
        RirNode::Filter { input, .. } => {
            let (scans, filters) = fallback_scan_filter_equivalents(input);
            (scans, filters.saturating_add(1))
        }
        RirNode::Project { input, .. }
        | RirNode::GroupBy { input, .. }
        | RirNode::Distinct { input, .. } => fallback_scan_filter_equivalents(input),
        RirNode::Join { left, right, .. } | RirNode::Diff { left, right } => {
            let left = fallback_scan_filter_equivalents(left);
            let right = fallback_scan_filter_equivalents(right);
            (
                left.0.saturating_add(right.0),
                left.1.saturating_add(right.1),
            )
        }
        RirNode::ChainJoin { fallback, .. } | RirNode::MultiWayJoin { fallback, .. } => {
            fallback_scan_filter_equivalents(fallback)
        }
        RirNode::Union { inputs } => inputs.iter().fold((0u64, 0u64), |total, input| {
            let current = fallback_scan_filter_equivalents(input);
            (
                total.0.saturating_add(current.0),
                total.1.saturating_add(current.1),
            )
        }),
        RirNode::Fixpoint {
            base, recursive, ..
        } => {
            let base = fallback_scan_filter_equivalents(base);
            let recursive = fallback_scan_filter_equivalents(recursive);
            (
                base.0.saturating_add(recursive.0),
                base.1.saturating_add(recursive.1),
            )
        }
    }
}

fn record_chain_fallback_equivalents(
    body: &RirNode,
    installed: bool,
    scan_equivalents: &mut u64,
    filter_equivalents: &mut u64,
) {
    if !installed {
        return;
    }
    let RirNode::ChainJoin { fallback, .. } = body else {
        return;
    };
    let (scans, filters) = fallback_scan_filter_equivalents(fallback);
    *scan_equivalents = scan_equivalents.saturating_add(scans);
    *filter_equivalents = filter_equivalents.saturating_add(filters);
}

/// Three rel IDs extracted from a matched triangle RIR. The
/// names correspond to the WCOJ kernel's slot semantics.
pub(super) struct TriangleRirMatch {
    /// Rel for the (X, Y) edge — left subtree of the inner join,
    /// joined with `rel_yz` on Y.
    pub rel_xy: RelId,
    /// Rel for the (Y, Z) edge — right subtree of the inner join.
    pub rel_yz: RelId,
    /// Rel for the (X, Z) closing edge — right subtree of the
    /// outer join, joined with the inner join's output on (X, Z).
    pub rel_xz: RelId,
}

/// Pattern-match a `RirNode::MultiWayJoin` whose structure is the
/// canonical triangle shape. Returns the three scan rel IDs in
/// WCOJ slot order on a successful match; `None` for any deviation.
///
/// The match is intentionally strict over `inputs`, `slot_vars`,
/// AND `output_columns`. The current triangle matcher certifies the
/// canonical (X, Y, Z) emit order; rotated head projections,
/// non-Scan inputs, or non-canonical variable classes decline
/// dispatch and the caller takes the embedded `fallback` path.
///
/// Future matcher work must generalize in tandem with kernel
/// generalization (4-way, n-way) — never one without the other.
pub(super) fn match_multiway_triangle(body: &RirNode) -> Option<TriangleRirMatch> {
    let RirNode::MultiWayJoin {
        inputs,
        slot_vars,
        output_columns,
        ..
    } = body
    else {
        return None;
    };
    if inputs.len() != 3 {
        return None;
    }
    if !slot_vars_match_canonical_triangle(slot_vars) {
        return None;
    }
    if !output_columns_match_canonical_triangle(output_columns) {
        return None;
    }
    let rel_xy = scan_rel(&inputs[0])?;
    let rel_yz = scan_rel(&inputs[1])?;
    let rel_xz = scan_rel(&inputs[2])?;
    Some(TriangleRirMatch {
        rel_xy,
        rel_yz,
        rel_xz,
    })
}

/// Confirm `slot_vars` is the canonical
/// `[[A, B], [B, C], [A, C]]` triangle shape with three distinct
/// variable-class ids. Anything else (rotated, dropped, repeated)
/// fails the match.
fn slot_vars_match_canonical_triangle(slot_vars: &[Vec<Option<u32>>]) -> bool {
    if slot_vars.len() != 3 {
        return false;
    }
    let s0 = &slot_vars[0];
    let s1 = &slot_vars[1];
    let s2 = &slot_vars[2];
    if s0.len() != 2 || s1.len() != 2 || s2.len() != 2 {
        return false;
    }
    let (a, b) = match (s0[0], s0[1]) {
        (Some(a), Some(b)) if a != b => (a, b),
        _ => return false,
    };
    let c = match (s1[0], s1[1]) {
        (Some(b1), Some(c)) if b1 == b && c != a && c != b => c,
        _ => return false,
    };
    matches!((s2[0], s2[1]), (Some(a2), Some(c2)) if a2 == a && c2 == c)
}

/// Confirm `output_columns` is one of the valid head-extraction
/// layouts. The GPU kernel writes triples in canonical
/// `(X, Y, Z)` order; the project columns describe the
/// binary-join-intermediate layout the head extracts from.
///
/// Accepted triangle output-column layouts:
///   * `[Column(0), Column(1), Column(3)]` — Y-shared /
///     X-shared inner pair (binary intermediate cols
///     [X, Y, Y, Z, X, Z] / [X, Y, X, Z, Y, Z]).
///   * `[Column(0), Column(2), Column(3)]` — Z-shared inner
///     pair (binary intermediate cols [X, Z, Y, Z, X, Y]).
fn output_columns_match_canonical_triangle(cols: &[ProjectExpr]) -> bool {
    if cols.len() != 3 {
        return false;
    }
    let cols_pattern = (
        matches!(cols[0], ProjectExpr::Column(0)),
        matches!(cols[1], ProjectExpr::Column(1)) || matches!(cols[1], ProjectExpr::Column(2)),
        matches!(cols[2], ProjectExpr::Column(3)),
    );
    cols_pattern == (true, true, true)
}

// -----------------------------------------------------------------
// 4-cycle matcher.
//
// Mirrors the triangle matcher with a shape-locked qualifier.
// -----------------------------------------------------------------

/// Four rel IDs extracted from a matched 4-cycle RIR.
pub(super) struct FourCycleRirMatch {
    pub rel_e1: RelId,
    pub rel_e2: RelId,
    pub rel_e3: RelId,
    pub rel_e4: RelId,
}

/// Pattern-match a `RirNode::MultiWayJoin` whose structure is the
/// canonical 4-cycle shape. Returns the four scan rel IDs in WCOJ
/// slot order on a successful match; `None` for any deviation.
///
/// The match is intentionally strict over `inputs`, `slot_vars`,
/// AND `output_columns`. The current 4-cycle matcher certifies the
/// canonical (W, X, Y, Z) emit order.
pub(super) fn match_multiway_4cycle(body: &RirNode) -> Option<FourCycleRirMatch> {
    let RirNode::MultiWayJoin {
        inputs,
        slot_vars,
        output_columns,
        ..
    } = body
    else {
        return None;
    };
    if inputs.len() != 4 {
        return None;
    }
    if !slot_vars_match_canonical_4cycle(slot_vars) {
        return None;
    }
    if !output_columns_match_canonical_4cycle(output_columns) {
        return None;
    }
    let rel_e1 = scan_rel(&inputs[0])?;
    let rel_e2 = scan_rel(&inputs[1])?;
    let rel_e3 = scan_rel(&inputs[2])?;
    let rel_e4 = scan_rel(&inputs[3])?;
    Some(FourCycleRirMatch {
        rel_e1,
        rel_e2,
        rel_e3,
        rel_e4,
    })
}

/// Confirm `slot_vars` is the canonical
/// `[[A, B], [B, C], [C, D], [D, A]]` 4-cycle shape with four
/// distinct variable-class ids closing the cycle (slot 3's second
/// var equals slot 0's first var).
fn slot_vars_match_canonical_4cycle(slot_vars: &[Vec<Option<u32>>]) -> bool {
    if slot_vars.len() != 4 {
        return false;
    }
    for s in slot_vars {
        if s.len() != 2 {
            return false;
        }
    }
    let (a, b) = match (slot_vars[0][0], slot_vars[0][1]) {
        (Some(a), Some(b)) if a != b => (a, b),
        _ => return false,
    };
    let c = match (slot_vars[1][0], slot_vars[1][1]) {
        (Some(b1), Some(c)) if b1 == b && c != a && c != b => c,
        _ => return false,
    };
    let d = match (slot_vars[2][0], slot_vars[2][1]) {
        (Some(c1), Some(d)) if c1 == c && d != a && d != b && d != c => d,
        _ => return false,
    };
    matches!(
        (slot_vars[3][0], slot_vars[3][1]),
        (Some(d2), Some(a2)) if d2 == d && a2 == a
    )
}

/// Confirm `output_columns` is the certified `(W, X, Y, Z)` emit
/// order. The GPU kernel writes quads in this order.
/// Accepted 4-cycle output-column layouts:
///   * `[Column(0), Column(1), Column(3), Column(5)]` —
///     Default grouping `(WX⋈XY) + (YZ⋈ZW)`.
///   * `[Column(5), Column(0), Column(1), Column(3)]` — Alt
///     grouping `(XY⋈YZ) + (ZW⋈WX)` (binary intermediate
///     col 5 = W from inner-right; (W, X, Y, Z) extracts
///     from cols [5, 0, 1, 3]).
fn output_columns_match_canonical_4cycle(cols: &[ProjectExpr]) -> bool {
    if cols.len() != 4 {
        return false;
    }
    let exact = |idx: usize, want: usize| matches!(cols[idx], ProjectExpr::Column(c) if c == want);
    // Default layout.
    let default_layout = exact(0, 0) && exact(1, 1) && exact(2, 3) && exact(3, 5);
    // Alt layout.
    let alt_layout = exact(0, 5) && exact(1, 0) && exact(2, 1) && exact(3, 3);
    default_layout || alt_layout
}

/// Extract the `RelId` from a leaf `Scan` node, or `None` for
/// any non-Scan child. The current matcher only admits Scan leaves;
/// future matcher work may admit `Filter { Scan }` or projected
/// scans, but always in tandem with kernel support.
fn scan_rel(node: &RirNode) -> Option<RelId> {
    match node {
        RirNode::Scan { rel } => Some(*rel),
        _ => None,
    }
}

/// Physical key width for a WCOJ-eligible binary relation at
/// the RIR-level dispatch. `FourByte` covers `U32` and `Symbol`
/// (bit-identical layout); `EightByte` covers `U64`.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub(super) enum WcojKeyWidth {
    FourByte,
    EightByte,
}

/// Classify a binary [`CudaBuffer`]'s key width for WCOJ
/// dispatch, mirroring `xlog_integration::wcoj_dispatch`'s
/// AST-level helper. Returns `Some(width)` for 2-column buffers
/// whose columns are both 4-byte (U32/Symbol) or both 8-byte
/// (U64); `None` for any other arity / type combination,
/// including mixed-width within a single buffer.
///
/// Cross-relation type compatibility is enforced upstream by
/// the planner via `analyze_typed`. The executor only sees
/// lowered RIR at this point, so this classifier is the last
/// width-uniformity check before the GPU launch — any
/// divergence vs. the binary-join path is caught by the
/// wiring/cert row-set-equality tests.
fn classify_two_col_wcoj_width(buf: &CudaBuffer) -> Option<WcojKeyWidth> {
    if buf.arity() != 2 {
        return None;
    }
    let c0 = buf.schema().column_type(0)?;
    let c1 = buf.schema().column_type(1)?;
    let w0 = scalar_wcoj_width(c0)?;
    let w1 = scalar_wcoj_width(c1)?;
    if w0 != w1 {
        return None;
    }
    Some(w0)
}

fn scalar_wcoj_width(ty: xlog_core::ScalarType) -> Option<WcojKeyWidth> {
    match ty {
        xlog_core::ScalarType::U32 | xlog_core::ScalarType::Symbol => Some(WcojKeyWidth::FourByte),
        xlog_core::ScalarType::U64 => Some(WcojKeyWidth::EightByte),
        _ => None,
    }
}

/// Convert `kernel_output_cols` (a `Vec<ProjectExpr>`) into
/// the `Vec<usize>` permutation that
/// `wcoj_project_output_columns_recorded` consumes. Triangle and
/// 4-cycle kernel_output_cols entries are always
/// `ProjectExpr::Column(_)` per the locked permutation tables in
/// `xlog_logic::wcoj_var_ordering`; anything else is a planner bug.
/// Derive the slot-0 joined-with slot-1 feedback pair and the
/// underlying-relation key columns from `var_order`.
///
/// Returns `(rel_a, rel_b, left_keys, right_keys)` where keys
/// are NATIVE (pre-swap) column indices on the underlying
/// relations — `record_join_result` stores keys against native
/// indexing. For triangle non-default leaders, slot 1 is a
/// 2-col SWAPPED view of the underlying relation; the kernel
/// invariant `slot0.col1 ≡ slot1.col0` holds for the views
/// but maps to native key index 1 on BOTH sides.
///
/// **Rotated-feedback table**:
///
/// | Shape    | Leader            | (rel_a, rel_b)      | (left_keys, right_keys) |
/// |----------|-------------------|---------------------|-------------------------|
/// | Triangle | 0 (e_xy default)  | (slot[0], slot[1])  | [1] / [0] (no swap) |
/// | Triangle | 1 (e_yz)          | (slot[1], slot[2])  | **[1] / [1]** (slot 1 = e_xz↔) |
/// | Triangle | 2 (e_xz)          | (slot[2], slot[1])  | **[1] / [1]** (slot 1 = e_yz↔) |
/// | 4-cycle  | 0..3 (rotation)   | (slot[i], slot[i+1])| [1] / [0] (no swap) |
///
/// Returns `None` only if `slot_rels.len() < 2` (defensive).
fn feedback_pair_from_var_order(
    slot_rels: &[RelId],
    var_order: Option<&VariableOrder>,
) -> Option<(RelId, RelId, Vec<usize>, Vec<usize>)> {
    if slot_rels.len() < 2 {
        return None;
    }
    let Some(vo) = var_order else {
        // Default config / no rotation: canonical feedback
        // behavior: canonical (slot_rels[0], slot_rels[1]) with
        // keys [1] / [0].
        return Some((slot_rels[0], slot_rels[1], vec![1], vec![0]));
    };
    let leader_idx = vo.leader_idx as usize;
    match slot_rels.len() {
        3 => {
            // Triangle rotated-feedback table.
            match leader_idx {
                0 => Some((slot_rels[0], slot_rels[1], vec![1], vec![0])),
                1 => {
                    // Leader e_yz: slot 0 = rel_yz native, slot 1 =
                    // rel_xz **swapped** view. Native rel_xz has Z
                    // at col1, so [1]/[1].
                    Some((slot_rels[1], slot_rels[2], vec![1], vec![1]))
                }
                2 => {
                    // Leader e_xz: slot 0 = rel_xz native, slot 1 =
                    // rel_yz **swapped** view. Native rel_yz has Z
                    // at col1, so [1]/[1].
                    Some((slot_rels[2], slot_rels[1], vec![1], vec![1]))
                }
                _ => None,
            }
        }
        4 => {
            // 4-cycle: rotation-only, all slots in native layout,
            // keys [1]/[0] for every leader.
            if leader_idx >= 4 {
                return None;
            }
            let slot1_input_idx = (leader_idx + 1) % 4;
            Some((
                slot_rels[leader_idx],
                slot_rels[slot1_input_idx],
                vec![1],
                vec![0],
            ))
        }
        _ => None,
    }
}

fn perm_indices_from_kernel_output_cols(cols: &[ProjectExpr]) -> Result<Vec<usize>> {
    let mut out = Vec::with_capacity(cols.len());
    for c in cols {
        match c {
            ProjectExpr::Column(idx) => out.push(*idx),
            other => {
                return Err(xlog_core::XlogError::Kernel(format!(
                    "perm_indices_from_kernel_output_cols: \
                     kernel_output_cols must be ProjectExpr::Column(_), got {:?}",
                    other
                )));
            }
        }
    }
    Ok(out)
}

/// Build the canonical triangle head schema `(X, Y, Z)`
/// from the canonical promoter inputs. Used as the
/// `head_schema` argument to
/// `wcoj_project_output_columns_recorded` on the leader-ordered path.
fn build_triangle_head_schema(buf_xy: &CudaBuffer, buf_yz: &CudaBuffer) -> Result<Schema> {
    let x_type = buf_xy.schema().column_type(0).ok_or_else(|| {
        xlog_core::XlogError::Kernel("build_triangle_head_schema: e_xy.col0 type missing".into())
    })?;
    let y_type = buf_xy.schema().column_type(1).ok_or_else(|| {
        xlog_core::XlogError::Kernel("build_triangle_head_schema: e_xy.col1 type missing".into())
    })?;
    let z_type = buf_yz.schema().column_type(1).ok_or_else(|| {
        xlog_core::XlogError::Kernel("build_triangle_head_schema: e_yz.col1 type missing".into())
    })?;
    Schema::new(vec![
        ("col0".to_string(), x_type),
        ("col1".to_string(), y_type),
        ("col2".to_string(), z_type),
    ])
    .with_sort_labels(vec![
        buf_xy
            .schema()
            .column_sort_label(0)
            .unwrap_or("col0")
            .to_string(),
        buf_xy
            .schema()
            .column_sort_label(1)
            .unwrap_or("col1")
            .to_string(),
        buf_yz
            .schema()
            .column_sort_label(1)
            .unwrap_or("col2")
            .to_string(),
    ])
    .map_err(xlog_core::XlogError::Kernel)
}

/// Build the canonical 4-cycle head schema
/// `(W, X, Y, Z)` from the canonical promoter inputs.
fn build_4cycle_head_schema(
    buf_e1: &CudaBuffer,
    buf_e2: &CudaBuffer,
    buf_e3: &CudaBuffer,
) -> Result<Schema> {
    // `[e_wx, e_xy, e_yz, e_zw]` — canonical promoter order.
    // W = e_wx.col0, X = e_wx.col1 (= e_xy.col0), Y = e_xy.col1
    // (= e_yz.col0), Z = e_yz.col1 (= e_zw.col0).
    let w_type = buf_e1.schema().column_type(0).ok_or_else(|| {
        xlog_core::XlogError::Kernel("build_4cycle_head_schema: e_wx.col0 type missing".into())
    })?;
    let x_type = buf_e1.schema().column_type(1).ok_or_else(|| {
        xlog_core::XlogError::Kernel("build_4cycle_head_schema: e_wx.col1 type missing".into())
    })?;
    let y_type = buf_e2.schema().column_type(1).ok_or_else(|| {
        xlog_core::XlogError::Kernel("build_4cycle_head_schema: e_xy.col1 type missing".into())
    })?;
    let z_type = buf_e3.schema().column_type(1).ok_or_else(|| {
        xlog_core::XlogError::Kernel("build_4cycle_head_schema: e_yz.col1 type missing".into())
    })?;
    // Suppress the unused-import warning when ScalarType isn't
    // referenced in this scope (kept here for explicitness in case
    // a future change adds a width check).
    let _: ScalarType = w_type;
    Schema::new(vec![
        ("col0".to_string(), w_type),
        ("col1".to_string(), x_type),
        ("col2".to_string(), y_type),
        ("col3".to_string(), z_type),
    ])
    .with_sort_labels(vec![
        buf_e1
            .schema()
            .column_sort_label(0)
            .unwrap_or("col0")
            .to_string(),
        buf_e1
            .schema()
            .column_sort_label(1)
            .unwrap_or("col1")
            .to_string(),
        buf_e2
            .schema()
            .column_sort_label(1)
            .unwrap_or("col2")
            .to_string(),
        buf_e3
            .schema()
            .column_sort_label(1)
            .unwrap_or("col3")
            .to_string(),
    ])
    .map_err(xlog_core::XlogError::Kernel)
}

impl Executor {
    /// Try to dispatch a single non-recursive rule through the
    /// GPU WCOJ triangle kernel. Returns `Ok(Some(buffer))` if
    /// the dispatch fires and produces a result; `Ok(None)`
    /// otherwise (gate off, shape mismatch, missing buffer,
    /// non-4-byte-key schema, missing runtime, or kernel error — every
    /// failure mode is silent fallback).
    ///
    /// On `Ok(Some(_))`, the caller is responsible for installing
    /// the buffer into the relation store via the same path the
    /// existing binary-join branch uses.
    pub(super) fn try_dispatch_wcoj_triangle(
        &mut self,
        rule: &CompiledRule,
    ) -> Result<Option<CudaBuffer>> {
        // Body-keyed entry. Rule-keyed callers stay
        // byte-identical via this thin wrapper.
        self.try_dispatch_wcoj_triangle_on_body(&rule.body)
    }

    /// Read the WCOJ output buffer's logical row count.
    /// Returns `None` when the cache isn't populated. **Never
    /// returns `Some(0)` for an unknown row count** — only for
    /// an observed-empty output. The distinction matters for
    /// `record_wcoj_feedback`: an unknown count must skip the
    /// EMA update, not record selectivity 0.
    fn wcoj_output_rows(buf: &CudaBuffer) -> Option<u64> {
        // `CudaBuffer::cached_row_count` returns `Option<u32>`;
        // widen to `u64` for the `StatsManager` API.
        buf.cached_row_count().map(u64::from)
    }

    /// Wire successful WCOJ dispatches back into
    /// `StatsManager` so the cardinality cost model's future
    /// `binary_est` reads reflect observed selectivity.
    ///
    /// **Leader-aware routing**: the `(rel_a, rel_b, left_keys, right_keys)`
    /// quadruple is derived from the dispatched plan's
    /// `var_order` via `feedback_pair_from_var_order`, NOT
    /// hardcoded:
    ///
    /// * `var_order = None` (default config): returns the
    ///   canonical feedback pair, `(slot_rels[0], slot_rels[1])`
    ///   with keys `[1] / [0]`.
    /// * `var_order = Some(_)` (non-default leader): returns the rotated
    ///   pair from the locked feedback table — triangle
    ///   non-default leaders use rotated `(slot_rels[0],
    ///   slot_rels[1])` with keys `[1] / [1]` (Z-shared edges
    ///   in canonical layout join on col 1 of both rels);
    ///   4-cycle is rotation-only with keys `[1] / [0]`.
    ///
    /// `CardinalityAwareCostModel::should_dispatch_*` still
    /// reads via `estimate_join_cardinality` on the canonical
    /// default-leader pair — but on a non-default-leader run
    /// the dispatched layout's actual edge is what we observe,
    /// and that's what gets recorded under the rotated key.
    /// The leader-aware cost models look up rotated edges
    /// correspondingly; the writer ↔ reader pair stays
    /// coherent under each leader topology.
    ///
    /// Skips the recording when:
    ///   * `slot_rels.len() < 2` — not enough slots for a
    ///     binary inner pair (defensive).
    ///   * `output_rows == None` — unknown logical row count;
    ///     recording 0 would poison the EMA.
    ///   * `feedback_pair_from_var_order` returns `None` — the
    ///     leader rotation isn't in the locked feedback table
    ///     (conservative; never write under uncertainty).
    ///   * Any of `(rel_a, rel_b)` has missing or zero
    ///     cardinality; unknown inputs would compute a meaningless
    ///     `input_card_product`.
    ///
    /// Recording an observed-empty output (`Some(0)`) IS
    /// correct — the EMA tightens future estimates toward zero,
    /// so WCOJ becomes less likely on the same inputs next
    /// call (the kernel produced nothing useful).
    ///
    /// The triangle / 4-cycle output is a strict subset of the
    /// inner-join intermediate (the third / additional atoms
    /// further filter it). The recorded selectivity is
    /// therefore an UPPER BOUND on the true binary
    /// selectivity, which is the correct conservative direction
    /// for the cost model: it under-claims the WCOJ kernel's
    /// win rather than over-claiming.
    fn record_wcoj_feedback(
        &mut self,
        slot_rels: &[RelId],
        var_order: Option<&VariableOrder>,
        output_rows: Option<u64>,
    ) {
        if slot_rels.len() < 2 {
            return;
        }
        let Some(out_rows) = output_rows else {
            return;
        };
        // Derive the (slot 0, slot 1) feedback pair and the
        // underlying-relation key columns from `var_order`.
        // For `var_order = None` (default config), this returns
        // the canonical pair + keys [1]/[0]. For Some(_), the pair may be
        // rotated (triangle non-default leaders use rotated pair
        // + [1]/[1] keys; 4-cycle is rotation-only [1]/[0]).
        let Some((rel_a, rel_b, left_keys, right_keys)) =
            feedback_pair_from_var_order(slot_rels, var_order)
        else {
            return;
        };
        let card_a = self
            .stats
            .get_relation_stats(rel_a)
            .map(|s| s.cardinality)
            .filter(|c| *c > 0);
        let card_b = self
            .stats
            .get_relation_stats(rel_b)
            .map(|s| s.cardinality)
            .filter(|c| *c > 0);
        let (Some(a), Some(b)) = (card_a, card_b) else {
            return;
        };
        let input_rows = a.saturating_mul(b);
        // `record_join_result` takes owned `Vec<usize>` for the
        // key columns (signature predates this slice).
        self.stats
            .record_join_result(rel_a, rel_b, left_keys, right_keys, input_rows, out_rows);
    }

    /// Body-keyed entry point: same gate / pattern-match / dispatch
    /// logic as `try_dispatch_wcoj_triangle`, keyed on `body`
    /// rather than `&CompiledRule`. The recursive engine calls
    /// this on the rewritten variant body (one Scan's RelId
    /// swapped to a delta RelId); the rule-keyed wrapper above
    /// preserves the rule-keyed surface for non-recursive callers.
    pub(super) fn try_dispatch_wcoj_triangle_on_body(
        &mut self,
        body: &RirNode,
    ) -> Result<Option<CudaBuffer>> {
        #[cfg(feature = "wcoj-phase-timing")]
        let wall_start = Instant::now();
        // 1. Gate resolution. Decision tree (highest → lowest):
        //
        //    a. Runtime disable flag → no dispatch.
        //    b. If `wcoj_triangle_dispatch` resolves to true
        //       (config Some(true) or env=1) → force WCOJ.
        //    c. Force = Some(false) → explicit off.
        //    d. Else if stats mode resolves to true, consult
        //       the cardinality model.
        //    e. Else → no dispatch.
        if wcoj_triangle_disabled(self.config.wcoj_triangle_dispatch_disabled)? {
            return Ok(None);
        }
        let force_override = self.config.wcoj_triangle_dispatch;
        let force_on = wcoj_gate_enabled(force_override)?;
        let mode = if force_on {
            DispatchMode::Force
        } else {
            // Force-Some(false) is "explicitly off". Only when
            // force is None or env-default-off do we consult the
            // stats gate.
            let force_explicit_off = matches!(force_override, Some(false));
            if force_explicit_off {
                return Ok(None);
            }
            let adaptive_override = self.config.wcoj_triangle_dispatch_adaptive;
            if wcoj_adaptive_enabled(adaptive_override) {
                DispatchMode::CostModel
            } else {
                return Ok(None);
            }
        };

        // 2. Pattern-match the canonical-triangle MultiWayJoin.
        let Some(matched) = match_multiway_triangle(body) else {
            return Ok(None);
        };

        // 3. Resolve rel IDs to predicate names.
        // get_rel_name returns Option<&str> — bind to owned String
        // so the borrow doesn't conflict with later &mut self uses.
        let name_xy = match self.get_rel_name(matched.rel_xy) {
            Some(s) => s.to_string(),
            None => return Ok(None),
        };
        let name_yz = match self.get_rel_name(matched.rel_yz) {
            Some(s) => s.to_string(),
            None => return Ok(None),
        };
        let name_xz = match self.get_rel_name(matched.rel_xz) {
            Some(s) => s.to_string(),
            None => return Ok(None),
        };

        // 4. Look up input buffers + classify their key widths.
        // All three slots must be WCOJ-eligible AND share the
        // same width — mixed-width triangles fall back here so
        // the binary-join path handles them.
        let buf_xy = match self.store.get(&name_xy) {
            Some(b) => b,
            None => return Ok(None),
        };
        let buf_yz = match self.store.get(&name_yz) {
            Some(b) => b,
            None => return Ok(None),
        };
        let buf_xz = match self.store.get(&name_xz) {
            Some(b) => b,
            None => return Ok(None),
        };
        let width = match (
            classify_two_col_wcoj_width(buf_xy),
            classify_two_col_wcoj_width(buf_yz),
            classify_two_col_wcoj_width(buf_xz),
        ) {
            (Some(a), Some(b), Some(c)) if a == b && b == c => a,
            _ => return Ok(None),
        };

        // 5. Resolve the cached executor WCOJ launch stream.
        // Acquire-once / reuse-forever (mirrors
        // `CudaKernelProvider::recorded_op_stream`). Acquiring
        // per-invocation would silently drain the
        // `StreamPool` (default cap 16, grow-only) on long-
        // lived runtimes — once exhausted, subsequent
        // dispatches would silently fall back to binary-join
        // and the dispatch counter would stop incrementing.
        // Without a runtime-backed manager, the recorded WCOJ
        // primitives can't run — fall back silently.
        if self.provider.memory().runtime().is_none() {
            return Ok(None);
        }
        let launch_stream = match self.wcoj_dispatch_stream_or_init() {
            Some(s) => s,
            None => return Ok(None),
        };

        // 6. Stats-backed mode only: resolve the WCOJ cost model
        // on the same launch stream as the eventual GPU pipeline.
        #[cfg(feature = "wcoj-phase-timing")]
        let mut classifier_ms: f32 = 0.0;
        if mode == DispatchMode::CostModel {
            #[cfg(feature = "wcoj-phase-timing")]
            let cls_start = Instant::now();
            let model = super::wcoj_cost_model::build_wcoj_cost_model(&self.config);
            let slot_rels = [matched.rel_xy, matched.rel_yz, matched.rel_xz];
            let ctx = super::wcoj_cost_model::WcojDispatchCtx {
                stats: &self.stats,
                slot_rels: &slot_rels,
            };
            let dispatch = model.should_dispatch_triangle(&ctx);
            #[cfg(feature = "wcoj-phase-timing")]
            {
                classifier_ms = cls_start.elapsed().as_secs_f64() as f32 * 1000.0;
            }
            if !dispatch {
                return Ok(None);
            }
        }

        // Extract var_order from the matched MultiWayJoin body. None preserves
        // default-leader dispatch bit-identically.
        let var_order_opt: Option<&VariableOrder> = match body {
            RirNode::MultiWayJoin { var_order, .. } => var_order.as_ref(),
            _ => None,
        };

        // 7. Run layout + triangle. Convert any kernel error to
        // silent fallback per dispatch contract ("failure must not
        // corrupt store state"). The WCOJ helpers don't write
        // to the store, so an error here only loses the work
        // we just did — the binary-join path picks it up.
        #[cfg(feature = "wcoj-phase-timing")]
        let mut layout_times: [f32; 3] = [0.0; 3];
        let dispatch_result = self.run_wcoj_triangle_pipeline(
            buf_xy,
            buf_yz,
            buf_xz,
            launch_stream,
            width,
            var_order_opt,
            #[cfg(feature = "wcoj-phase-timing")]
            &mut layout_times,
        );
        match dispatch_result {
            Ok(buf) => {
                // Record observed selectivity into
                // StatsManager for the cardinality cost model.
                // The (rel_a, rel_b, left_keys, right_keys) pair
                // is derived from `var_order_opt` via
                // `feedback_pair_from_var_order`:
                //   * `var_order = None` (default config) →
                //     canonical `(rel_xy, rel_yz)` keys
                //     `[1]/[0]`.
                //   * `var_order = Some(_)` (non-default leader) →
                //     rotated pair per the feedback table.
                //     Triangle non-default leaders use rotated
                //     `(slot_rels[0], slot_rels[1])` with keys
                //     `[1]/[1]` (Z-shared edges in canonical
                //     layout join on col 1 of both rels).
                // Helper handles skip-on-missing-data and is
                // called BEFORE the counter increment so a
                // helper panic doesn't advance the counter.
                let output_rows = Self::wcoj_output_rows(&buf);
                let slot_rels = [matched.rel_xy, matched.rel_yz, matched.rel_xz];
                self.record_wcoj_feedback(&slot_rels, var_order_opt, output_rows);
                self.wcoj_triangle_dispatch_count += 1;
                #[cfg(feature = "wcoj-phase-timing")]
                {
                    let triangle_timing = self
                        .provider
                        .take_wcoj_triangle_phase_timing()
                        .unwrap_or_default();
                    let wall_ms = wall_start.elapsed().as_secs_f64() as f32 * 1000.0;
                    let timing = super::wcoj_phase_timing::WcojDispatchPhaseTiming::new(
                        classifier_ms,
                        layout_times[0],
                        layout_times[1],
                        layout_times[2],
                        triangle_timing,
                        wall_ms,
                    );
                    if let Ok(mut g) = self.last_wcoj_phase_timing.lock() {
                        *g = Some(timing);
                    }
                }
                Ok(Some(buf))
            }
            Err(err) => wcoj_decline_on_error(&mut self.wcoj_error_decline_count, "triangle", err),
        }
    }

    /// Inner pipeline: 3× layout construction + triangle kernel.
    /// Split out so [`try_dispatch_wcoj_triangle`] can map any
    /// error to `Ok(None)` cleanly. Branches by `width` between
    /// the parallel u32 and u64 provider entries.
    ///
    /// Under feature `wcoj-phase-timing`, fills the optional
    /// `layout_times_ms` slot with `[layout_xy, layout_yz, layout_xz]`
    /// wall times in milliseconds. The triangle's per-phase GPU
    /// times are pulled from the provider via
    /// `take_wcoj_triangle_phase_timing` after this returns.
    #[cfg_attr(
        feature = "wcoj-phase-timing",
        expect(
            clippy::too_many_arguments,
            reason = "triangle dispatch keeps three typed inputs, stream, width, variable order, and optional timing output explicit"
        )
    )]
    fn run_wcoj_triangle_pipeline(
        &self,
        buf_xy: &CudaBuffer,
        buf_yz: &CudaBuffer,
        buf_xz: &CudaBuffer,
        launch_stream: StreamId,
        width: WcojKeyWidth,
        var_order: Option<&VariableOrder>,
        #[cfg(feature = "wcoj-phase-timing")] layout_times_ms: &mut [f32; 3],
    ) -> Result<CudaBuffer> {
        // When the cost model selected a non-default leader,
        // run the rotated/swapped path. Layout helper sees the
        // (possibly col-swapped) leader-rotated inputs; kernel
        // emits in (a, b, c) order; final projection helper remaps
        // to the canonical (X, Y, Z) head order.
        if let Some(vo) = var_order {
            return self.run_wcoj_triangle_pipeline_with_leader_order(
                buf_xy,
                buf_yz,
                buf_xz,
                launch_stream,
                width,
                vo,
            );
        }
        #[cfg(feature = "wcoj-phase-timing")]
        let mut time_layout =
            |f: &dyn Fn() -> Result<CudaBuffer>, slot: usize| -> Result<CudaBuffer> {
                let s = Instant::now();
                let r = f()?;
                layout_times_ms[slot] = s.elapsed().as_secs_f64() as f32 * 1000.0;
                Ok(r)
            };
        match width {
            WcojKeyWidth::FourByte => {
                #[cfg(feature = "wcoj-phase-timing")]
                let (layout_xy, layout_yz, layout_xz) = {
                    let xy = time_layout(
                        &|| {
                            self.provider
                                .wcoj_layout_u32_recorded(buf_xy, launch_stream)
                        },
                        0,
                    )?;
                    let yz = time_layout(
                        &|| {
                            self.provider
                                .wcoj_layout_u32_recorded(buf_yz, launch_stream)
                        },
                        1,
                    )?;
                    let xz = time_layout(
                        &|| {
                            self.provider
                                .wcoj_layout_u32_recorded(buf_xz, launch_stream)
                        },
                        2,
                    )?;
                    (xy, yz, xz)
                };
                #[cfg(not(feature = "wcoj-phase-timing"))]
                let layout_xy = self
                    .provider
                    .wcoj_layout_u32_recorded(buf_xy, launch_stream)?;
                #[cfg(not(feature = "wcoj-phase-timing"))]
                let layout_yz = self
                    .provider
                    .wcoj_layout_u32_recorded(buf_yz, launch_stream)?;
                #[cfg(not(feature = "wcoj-phase-timing"))]
                let layout_xz = self
                    .provider
                    .wcoj_layout_u32_recorded(buf_xz, launch_stream)?;
                let out = self.provider.wcoj_triangle_hg_u32_recorded(
                    &layout_xy,
                    &layout_yz,
                    &layout_xz,
                    wcoj_block_work_unit(),
                    launch_stream,
                )?;
                self.provider.record_wcoj_triangle_hg_dispatch();
                Ok(out)
            }
            WcojKeyWidth::EightByte => {
                #[cfg(feature = "wcoj-phase-timing")]
                let (layout_xy, layout_yz, layout_xz) = {
                    let xy = time_layout(
                        &|| {
                            self.provider
                                .wcoj_layout_u64_recorded(buf_xy, launch_stream)
                        },
                        0,
                    )?;
                    let yz = time_layout(
                        &|| {
                            self.provider
                                .wcoj_layout_u64_recorded(buf_yz, launch_stream)
                        },
                        1,
                    )?;
                    let xz = time_layout(
                        &|| {
                            self.provider
                                .wcoj_layout_u64_recorded(buf_xz, launch_stream)
                        },
                        2,
                    )?;
                    (xy, yz, xz)
                };
                #[cfg(not(feature = "wcoj-phase-timing"))]
                let layout_xy = self
                    .provider
                    .wcoj_layout_u64_recorded(buf_xy, launch_stream)?;
                #[cfg(not(feature = "wcoj-phase-timing"))]
                let layout_yz = self
                    .provider
                    .wcoj_layout_u64_recorded(buf_yz, launch_stream)?;
                #[cfg(not(feature = "wcoj-phase-timing"))]
                let layout_xz = self
                    .provider
                    .wcoj_layout_u64_recorded(buf_xz, launch_stream)?;
                self.provider.wcoj_triangle_u64_recorded(
                    &layout_xy,
                    &layout_yz,
                    &layout_xz,
                    launch_stream,
                )
            }
        }
    }

    /// Pipeline for non-default leaders. Uses the permutation tables on
    /// `var_order` to:
    /// 1. Rotate canonical inputs `[buf_xy, buf_yz, buf_xz]` so the
    ///    leader sits at slot 0.
    /// 2. Apply col-swap (via `wcoj_project_2col_swap_recorded`) to
    ///    any non-leader slot whose `LookupPerm.swap_cols` is true.
    ///    Triangle e_yz / e_xz leaders need swaps; 4-cycle is
    ///    rotation-only (no swap entries).
    /// 3. Run `wcoj_layout_*_recorded` on each slot input.
    /// 4. Run `wcoj_triangle_*_recorded`. Kernel emits 3 columns
    ///    in leader's `(a, b, c)` order.
    /// 5. Apply `wcoj_project_output_columns_recorded` with
    ///    `var_order.kernel_output_cols` to re-permute the
    ///    kernel-direct output into the canonical head order
    ///    `(X, Y, Z)`.
    ///
    /// Phase timing is intentionally NOT instrumented on this path; performance
    /// validation for the non-default leader threshold is handled by benchmark
    /// evidence outside this helper.
    fn run_wcoj_triangle_pipeline_with_leader_order(
        &self,
        buf_xy: &CudaBuffer,
        buf_yz: &CudaBuffer,
        buf_xz: &CudaBuffer,
        launch_stream: StreamId,
        width: WcojKeyWidth,
        var_order: &VariableOrder,
    ) -> Result<CudaBuffer> {
        let canonical: [&CudaBuffer; 3] = [buf_xy, buf_yz, buf_xz];
        let slot_inputs = self.prepare_leader_inputs(&canonical, var_order, launch_stream)?;
        if slot_inputs.len() != 3 {
            return Err(xlog_core::XlogError::Kernel(
                "run_wcoj_triangle_pipeline_with_leader_order: prepare_leader_inputs must return 3 slots"
                    .to_string(),
            ));
        }

        // Build the canonical (X, Y, Z) head schema from the
        // canonical promoter inputs (NOT the rotated kernel
        // inputs). The kernel will emit in (a, b, c) order under
        // the rotated leader; the final projection helper maps
        // back to head order using kernel_output_cols.
        let head_schema = build_triangle_head_schema(buf_xy, buf_yz)?;
        let perm = perm_indices_from_kernel_output_cols(&var_order.kernel_output_cols)?;

        let kernel_out: CudaBuffer = match width {
            WcojKeyWidth::FourByte => {
                let l0 = self
                    .provider
                    .wcoj_layout_u32_recorded(&slot_inputs[0], launch_stream)?;
                let l1 = self
                    .provider
                    .wcoj_layout_u32_recorded(&slot_inputs[1], launch_stream)?;
                let l2 = self
                    .provider
                    .wcoj_layout_u32_recorded(&slot_inputs[2], launch_stream)?;
                let out = self.provider.wcoj_triangle_hg_u32_recorded(
                    &l0,
                    &l1,
                    &l2,
                    wcoj_block_work_unit(),
                    launch_stream,
                )?;
                self.provider.record_wcoj_triangle_hg_dispatch();
                out
            }
            WcojKeyWidth::EightByte => {
                let l0 = self
                    .provider
                    .wcoj_layout_u64_recorded(&slot_inputs[0], launch_stream)?;
                let l1 = self
                    .provider
                    .wcoj_layout_u64_recorded(&slot_inputs[1], launch_stream)?;
                let l2 = self
                    .provider
                    .wcoj_layout_u64_recorded(&slot_inputs[2], launch_stream)?;
                self.provider
                    .wcoj_triangle_u64_recorded(&l0, &l1, &l2, launch_stream)?
            }
        };

        self.provider.wcoj_project_output_columns_recorded(
            &kernel_out,
            &perm,
            head_schema,
            launch_stream,
        )
    }

    /// Number of times the WCOJ triangle hook produced a result
    /// and the executor installed it. Used by tests to assert
    /// that the WCOJ path actually ran (vs. silently falling
    /// back to the existing binary-join path with the same
    /// answer).
    pub fn wcoj_triangle_dispatch_count(&self) -> u64 {
        self.wcoj_triangle_dispatch_count
    }

    /// Number of WCOJ pipeline errors (layout or kernel failures, across
    /// triangle / 4-cycle / k-clique / chain hooks) that were converted
    /// into binary-join declines. Healthy dispatch keeps this at 0; a
    /// nonzero value is the signature of a regressed WCOJ pipeline hiding
    /// behind the silent-fallback contract. Set `XLOG_WCOJ_STRICT=1` to
    /// propagate such errors instead of declining.
    pub fn wcoj_error_decline_count(&self) -> u64 {
        self.wcoj_error_decline_count
    }

    /// Actual fallback executions after a WCOJ-family route declined.
    pub fn wcoj_fallback_stats(&self) -> crate::profiler::WcojFallbackStats {
        self.wcoj_fallback
    }

    /// Record the one fallback that is about to execute for a specialized body.
    pub(super) fn record_wcoj_body_fallback(&mut self, body: &RirNode) {
        match body {
            RirNode::ChainJoin { .. } => {
                self.wcoj_fallback.chain = self.wcoj_fallback.chain.saturating_add(1);
            }
            RirNode::MultiWayJoin {
                plan: Some(MultiwayPlan::FreeJoin),
                ..
            } => {
                self.wcoj_fallback.free_join = self.wcoj_fallback.free_join.saturating_add(1);
            }
            RirNode::MultiWayJoin {
                plan: Some(MultiwayPlan::PlannedHashRoute { .. }),
                ..
            } => {
                self.wcoj_fallback.planned_hash = self.wcoj_fallback.planned_hash.saturating_add(1);
            }
            RirNode::MultiWayJoin { .. } => {
                self.wcoj_fallback.dedicated_multiway =
                    self.wcoj_fallback.dedicated_multiway.saturating_add(1);
            }
            _ => {}
        }
    }

    /// Record a qualifying recursive chain that declined factorized delta.
    pub(super) fn record_factorized_delta_fallback(&mut self, body: &RirNode) {
        if matches!(body, RirNode::ChainJoin { .. }) {
            self.wcoj_fallback.factorized_delta =
                self.wcoj_fallback.factorized_delta.saturating_add(1);
        }
    }

    /// Record an aggregate-capable multiway body that used ordinary group-by.
    pub(super) fn record_wcoj_groupby_fallback(&mut self, input: &RirNode) {
        if matches!(input, RirNode::MultiWayJoin { .. }) {
            self.wcoj_fallback.groupby_fusion = self.wcoj_fallback.groupby_fusion.saturating_add(1);
        }
    }

    /// Count of times the generalized Free Join dispatch produced
    /// the installed result (vs. the embedded binary fallback).
    pub fn free_join_dispatch_count(&self) -> u64 {
        self.free_join_dispatch_count
    }

    /// Count of times the factorized recursive-delta dispatch produced the
    /// installed novel set (vs. the legacy hash-join -> diff path).
    pub fn factorized_delta_dispatch_count(&self) -> u64 {
        self.factorized_delta_dispatch_count
    }

    /// Layout-normalize one factorized-delta static side key-first:
    /// key column 0 feeds the layout helper directly; key column 1 is
    /// column-swapped through the recorded projection first.
    fn factorized_delta_normalize_static(
        &self,
        buf: &CudaBuffer,
        key_col: usize,
        launch_stream: StreamId,
    ) -> Result<CudaBuffer> {
        if key_col == 0 {
            return self.provider.wcoj_layout_u32_recorded(buf, launch_stream);
        }
        let ty = |i: usize| {
            buf.schema().column_type(i).ok_or_else(|| {
                xlog_core::XlogError::Execution(format!(
                    "factorized-delta: static column {i} type missing"
                ))
            })
        };
        let swapped = Schema::new(vec![("k".to_string(), ty(1)?), ("v".to_string(), ty(0)?)]);
        let projected = self.provider.wcoj_project_output_columns_recorded(
            buf,
            &[1, 0],
            swapped,
            launch_stream,
        )?;
        self.provider
            .wcoj_layout_u32_recorded(&projected, launch_stream)
    }

    /// Dispatch one semi-naive delta step through the factorized novel-set
    /// pipeline (`fj_delta_novel_u32_recorded`). Accepts the
    /// per-occurrence delta-rewritten variant body when it is a
    /// `ChainJoin` over two Scans with exactly one scanning the delta
    /// relation; the returned buffer is the head-order novel set —
    /// already diffed against `head_pred`'s stable relation and
    /// full-row deduped, so the caller may skip the legacy diff when
    /// every contribution to the head went through this path.
    ///
    /// Declines (silent, `Ok(None)`): kill switch, non-ChainJoin or
    /// non-Scan children, zero/two delta occurrences, non-u32/Symbol
    /// or non-arity-2 schemas, missing store buffers, head projection
    /// that is not a permutation of {delta carry, static value},
    /// dense-domain bound over the cap (cached per fixpoint), and the
    /// per-iteration work floor. Pipeline errors route through
    /// [`wcoj_decline_on_error`] ("factorized-delta" stage).
    pub(super) fn try_dispatch_factorized_delta(
        &mut self,
        node: &RirNode,
        delta_rel: RelId,
        head_pred: &str,
        recursive_preds: &HashSet<String>,
        ctx: &mut FactorizedDeltaCtx,
    ) -> Result<Option<CudaBuffer>> {
        use xlog_cuda::provider::FjDeltaCols;

        if factorized_delta_disabled()? {
            return Ok(None);
        }
        let RirNode::ChainJoin {
            left,
            right,
            left_key,
            right_key,
            output_columns,
            ..
        } = node
        else {
            return Ok(None);
        };
        let (RirNode::Scan { rel: left_rel }, RirNode::Scan { rel: right_rel }) =
            (left.as_ref(), right.as_ref())
        else {
            return Ok(None);
        };
        // Exactly one side scans the delta (per-occurrence variant
        // rewriting guarantees one occurrence; a delta-delta chain or
        // a chain not touching the delta both decline).
        let delta_on_left = match (*left_rel == delta_rel, *right_rel == delta_rel) {
            (true, false) => true,
            (false, true) => false,
            _ => return Ok(None),
        };
        let (delta_key, static_rel, static_key) = if delta_on_left {
            (*left_key, *right_rel, *right_key)
        } else {
            (*right_key, *left_rel, *left_key)
        };
        if delta_key > 1 || static_key > 1 {
            return Ok(None);
        }
        let delta_carry = 1 - delta_key;
        let static_value = 1 - static_key;

        // Head projection must be a permutation of {delta carry,
        // static value} in the combined left+right column space.
        let (delta_off, static_off) = if delta_on_left { (0, 2) } else { (2, 0) };
        let carry_global = delta_off + delta_carry;
        let value_global = static_off + static_value;
        let [ProjectExpr::Column(out0), ProjectExpr::Column(out1)] = output_columns.as_slice()
        else {
            return Ok(None);
        };
        let (r_carry, r_value) = if (*out0, *out1) == (carry_global, value_global) {
            (0, 1)
        } else if (*out0, *out1) == (value_global, carry_global) {
            (1, 0)
        } else {
            return Ok(None);
        };

        // Resolve store buffers; all three must be arity-2 u32/Symbol.
        let binary_u32_class = |buf: &CudaBuffer| {
            buf.arity() == 2
                && (0..2).all(|i| {
                    matches!(
                        buf.schema().column_type(i),
                        Some(ScalarType::U32) | Some(ScalarType::Symbol)
                    )
                })
        };
        let Some(delta_name) = self.get_rel_name(delta_rel).map(str::to_string) else {
            return Ok(None);
        };
        let Some(static_name) = self.get_rel_name(static_rel).map(str::to_string) else {
            return Ok(None);
        };
        let Some(delta_buf) = self.store.get(&delta_name) else {
            return Ok(None);
        };
        let Some(static_buf) = self.store.get(&static_name) else {
            return Ok(None);
        };
        let Some(full_buf) = self.store.get(head_pred) else {
            return Ok(None);
        };
        if !binary_u32_class(delta_buf)
            || !binary_u32_class(static_buf)
            || !binary_u32_class(full_buf)
        {
            return Ok(None);
        }
        if self.provider.memory().runtime().is_none() {
            return Ok(None);
        }
        let Some(launch_stream) = self.wcoj_dispatch_stream_or_init() else {
            return Ok(None);
        };

        // Dense-domain bound, computed once per (head, static) per
        // fixpoint at the first dispatch attempt (induction: every
        // derived id comes from the seeded delta, the stable head
        // relation, or the static side — exactly the iteration-1
        // sets). The in-kernel bounds check stays as the fail-closed
        // backstop.
        // Domain bound (max id + 1), computed once per (head, static)
        // per fixpoint (induction: every derived id comes from the
        // seeded delta, the stable head relation, or the static side).
        // `None` only when an id is u32::MAX — neither the dense
        // bitvector (domain overflow) nor the sparse hash set (the
        // forbidden (MAX,MAX) key) can pack it, so decline for the
        // whole fixpoint.
        let domain_key = (head_pred.to_string(), static_rel);
        let domain = match ctx.domain_by_key.get(&domain_key) {
            Some(Some(d)) => *d,
            Some(None) => return Ok(None),
            None => {
                let max_id = match self.provider.fj_delta_columns_max_u32(
                    &[
                        (delta_buf, &[0, 1][..]),
                        (static_buf, &[0, 1][..]),
                        (full_buf, &[0, 1][..]),
                    ],
                    launch_stream,
                ) {
                    Ok(m) => m,
                    Err(err) => {
                        return wcoj_decline_on_error(
                            &mut self.wcoj_error_decline_count,
                            "factorized-delta",
                            err,
                        );
                    }
                };
                let decided = if max_id == u32::MAX {
                    None
                } else {
                    Some(max_id + 1)
                };
                ctx.domain_by_key.insert(domain_key, decided);
                match decided {
                    Some(d) => d,
                    None => return Ok(None),
                }
            }
        };

        let n_delta = u64::from(self.buffer_row_count(delta_buf)?);
        let n_static = u64::from(self.buffer_row_count(static_buf)?);
        if n_delta == 0 || n_static == 0 {
            return Ok(None);
        }

        // Route: dense characteristic-bitvector when the domain fits
        // the cap (default 2¹⁴, env up to 2¹⁶); sparse hash set
        // otherwise. The bitvector's popcount+scan floor over
        // n_words = domain·⌈domain/32⌉ is a domain² term, so it gates
        // ONLY the dense route — applying it to a large-domain sparse
        // step would spuriously bail every iteration.
        let dense = domain <= factorized_delta_max_domain();
        if dense {
            let n_words = u64::from(domain.div_ceil(32)) * u64::from(domain);
            let work_est = n_delta.saturating_mul((n_static / u64::from(domain)).max(1));
            if work_est < n_words / factorized_delta_work_divisor() {
                return Ok(None);
            }
        }

        // Static side key-first layout. EDB statics are normalized
        // once per fixpoint (cached); a recursive static (non-linear
        // self-join — the stable relation itself) changes every
        // iteration and is re-normalized (it is already sorted+deduped
        // from union_gpu, so the layout fast-path applies).
        let static_is_recursive = recursive_preds.contains(&static_name);
        let norm_owned;
        let static_norm: &CudaBuffer = if static_is_recursive {
            norm_owned =
                match self.factorized_delta_normalize_static(static_buf, static_key, launch_stream)
                {
                    Ok(b) => b,
                    Err(err) => {
                        return wcoj_decline_on_error(
                            &mut self.wcoj_error_decline_count,
                            "factorized-delta",
                            err,
                        );
                    }
                };
            &norm_owned
        } else {
            match ctx.static_norm_cache.entry((static_rel, static_key)) {
                std::collections::hash_map::Entry::Occupied(e) => &*e.into_mut(),
                std::collections::hash_map::Entry::Vacant(v) => {
                    let norm = match self.factorized_delta_normalize_static(
                        static_buf,
                        static_key,
                        launch_stream,
                    ) {
                        Ok(b) => b,
                        Err(err) => {
                            return wcoj_decline_on_error(
                                &mut self.wcoj_error_decline_count,
                                "factorized-delta",
                                err,
                            );
                        }
                    };
                    &*v.insert(norm)
                }
            }
        };

        let cols = FjDeltaCols {
            delta_carry,
            delta_key,
            r_carry,
            r_value,
        };
        if dense {
            match self.provider.fj_delta_novel_u32_recorded(
                delta_buf,
                static_norm,
                full_buf,
                cols,
                domain,
                launch_stream,
            ) {
                Ok(novel) => {
                    self.factorized_delta_dispatch_count += 1;
                    Ok(Some(novel))
                }
                Err(err) => wcoj_decline_on_error(
                    &mut self.wcoj_error_decline_count,
                    "factorized-delta",
                    err,
                ),
            }
        } else {
            // Sparse route: cap the conservative hash table at half the
            // device budget; over that, the entry returns Ok(None) and
            // we fall back to the legacy hash-join → diff path.
            let max_table_bytes =
                factorized_delta_max_table_bytes(self.provider.memory().budget().device_bytes);
            match self.provider.fj_delta_sparse_novel_u32_recorded(
                delta_buf,
                static_norm,
                full_buf,
                cols,
                max_table_bytes,
                launch_stream,
            ) {
                Ok(Some(novel)) => {
                    self.factorized_delta_dispatch_count += 1;
                    Ok(Some(novel))
                }
                Ok(None) => Ok(None),
                Err(err) => wcoj_decline_on_error(
                    &mut self.wcoj_error_decline_count,
                    "factorized-delta",
                    err,
                ),
            }
        }
    }

    /// Dispatch a general `MultiWayJoin` (any shape WITHOUT a
    /// dedicated kernel) through the Free Join frontier engine. Runs
    /// after the triangle/4-cycle/k-clique dispatchers in
    /// `execute_wcoj_or_fallback_node`, and accepts ONLY nodes
    /// carrying `MultiwayPlan::FreeJoin` — the general promoter's
    /// provenance marker guaranteeing `output_columns` lives in the
    /// concatenated-inputs column space (dedicated promoters reorder
    /// `inputs` canonically, so positional interpretation of their
    /// nodes would permute the head). The plan is derived
    /// `binary2fj`-style over the node's slot order with
    /// earliest-node probe pushing (paper §4.1); probe keys must form
    /// a PREFIX of each atom's column order (flat sorted tries
    /// consume columns physically left-to-right) — non-prefix bodies
    /// decline silently to the fallback. Pipeline errors route
    /// through [`wcoj_decline_on_error`] ("free-join" stage).
    pub(super) fn try_dispatch_free_join(&mut self, node: &RirNode) -> Result<Option<CudaBuffer>> {
        use xlog_cuda::provider::{FjNode, FjPlan, FjSubAtom};

        if free_join_disabled()? {
            return Ok(None);
        }
        let RirNode::MultiWayJoin {
            inputs,
            slot_vars,
            output_columns,
            plan,
            ..
        } = node
        else {
            return Ok(None);
        };
        // Provenance gate (design §3): accept ONLY nodes the general
        // multiway promoter marked `MultiwayPlan::FreeJoin`. Their
        // construction guarantees `inputs` are the fallback's Scan
        // leaves in traversal order, so `output_columns` (fallback
        // projection space, the universal MultiWayJoin convention)
        // coincides with the concatenated-inputs space this
        // dispatcher projects from. Dedicated-shape promoters
        // (triangle / 4-cycle / K-clique) reorder `inputs`
        // canonically — interpreting their `output_columns`
        // positionally would permute the head — and they carry
        // `None` / `WcojWithPlan` / `PlannedHashRoute`, so the gate
        // also subsumes the dedicated-shape carve-out.
        if !matches!(plan, Some(MultiwayPlan::FreeJoin)) {
            return Ok(None);
        }
        if inputs.len() < 3 {
            return Ok(None);
        }
        // Resolve scans -> store buffers; all columns across all
        // inputs must share ONE width class — u32/Symbol or u64
        // (mixed widths and other types decline; the engine's flat
        // sorted-range tries are width-uniform per execution).
        let mut bufs: Vec<&CudaBuffer> = Vec::with_capacity(inputs.len());
        let mut all_u32 = true;
        let mut all_u64 = true;
        for input in inputs {
            let RirNode::Scan { rel } = input else {
                return Ok(None);
            };
            let name = match self.get_rel_name(*rel) {
                Some(s) => s.to_string(),
                None => return Ok(None),
            };
            let Some(buf) = self.store.get(&name) else {
                return Ok(None);
            };
            for i in 0..buf.arity() {
                match buf.schema().column_type(i) {
                    Some(ScalarType::U32 | ScalarType::Symbol) => all_u64 = false,
                    Some(ScalarType::U64) => all_u32 = false,
                    _ => return Ok(None),
                }
            }
            bufs.push(buf);
        }
        if !all_u32 && !all_u64 {
            return Ok(None);
        }
        // Fail-open cost-model loss veto: decline Free Join to the binary
        // fallback only when the cost model has full stats AND the join
        // is provably small (largest input below the WCOJ-worthwhile
        // threshold), the measured 1.7–2.0× cost-of-generality region.
        // Stats absent / any large input → FJ proceeds (every measured
        // win preserved). Inputs are all Scans (checked above).
        {
            let slot_rels: Vec<RelId> = inputs
                .iter()
                .filter_map(|i| match i {
                    RirNode::Scan { rel } => Some(*rel),
                    _ => None,
                })
                .collect();
            let model = super::wcoj_cost_model::build_wcoj_cost_model(&self.config);
            let ctx = super::wcoj_cost_model::WcojDispatchCtx {
                stats: &self.stats,
                slot_rels: &slot_rels,
            };
            if model.factorized_loss_veto(&ctx) {
                return Ok(None);
            }
        }
        // Dense variable ids: remap slot_vars' class ids to 0..n.
        let mut class_to_var: Vec<u32> = Vec::new();
        let mut dense = |class: u32| -> usize {
            match class_to_var.iter().position(|c| *c == class) {
                Some(i) => i,
                None => {
                    class_to_var.push(class);
                    class_to_var.len() - 1
                }
            }
        };
        let mut atom_vars: Vec<Vec<usize>> = Vec::with_capacity(slot_vars.len());
        for (i, cols) in slot_vars.iter().enumerate() {
            if cols.len() != bufs[i].arity() {
                return Ok(None);
            }
            let mut vars = Vec::with_capacity(cols.len());
            for c in cols {
                let Some(class) = c else { return Ok(None) };
                vars.push(dense(*class));
            }
            atom_vars.push(vars);
        }
        let num_vars = class_to_var.len();
        // Prefix-key-joinable order planner (decline-or-reorder).
        // Free Join's probe-key rule forces a left-deep prefix in COLUMN
        // order, so a bad atom order can materialize a large intermediate even
        // when the result is tiny (a measured worst case is ~3x peak vs
        // binary). The planner is a
        // safety net: it keeps the traversal order when it is already
        // competitive with the binary plan (every winning fixture untouched),
        // reorders to a better prefix-key-joinable order when one exists, or
        // declines to the binary fallback when none is competitive.
        // Cardinalities are the ground-truth row counts of the buffers we are
        // about to join (NOT StatsManager — always available, never activates
        // the loss veto on statless winners); per-pair join estimates consult
        // StatsManager when stats are populated. Only the CardinalityAware
        // model plans (SkewClassifier opt-out keeps the traversal order).
        let order: Vec<usize> = {
            let slot_rels: Vec<RelId> = inputs
                .iter()
                .filter_map(|i| match i {
                    RirNode::Scan { rel } => Some(*rel),
                    _ => None,
                })
                .collect();
            let cards: Vec<u64> = bufs.iter().map(|b| b.num_rows()).collect();
            let model = super::wcoj_cost_model::build_wcoj_cost_model(&self.config);
            let ctx = super::wcoj_cost_model::WcojDispatchCtx {
                stats: &self.stats,
                slot_rels: &slot_rels,
            };
            match model.plan_free_join_order(&ctx, &atom_vars, &cards) {
                super::wcoj_cost_model::FjOrderDecision::Decline => return Ok(None),
                super::wcoj_cost_model::FjOrderDecision::Reorder(o) => o,
                super::wcoj_cost_model::FjOrderDecision::KeepDefault => {
                    (0..atom_vars.len()).collect()
                }
            }
        };
        // binary2fj over the planned order with earliest-node probe pushing:
        // each atom's bound-variable PREFIX probes the earliest node
        // after which its keys are available; the unbound suffix covers
        // a new node. Repeated variables within one cover decline (the
        // provider's rebind check would reject them).
        let mut bound_at: Vec<Option<usize>> = vec![None; num_vars]; // var -> node idx
        let mut nodes: Vec<FjNode> = Vec::new();
        // Process atoms in the planned order; `i` stays the ORIGINAL input
        // index so `input_idx`/`bufs` indexing and the head projection
        // (`col_to_var`, built in original order below) remain correct — only
        // the prefix-materialization order changes.
        for &i in &order {
            let vars = &atom_vars[i];
            let split = vars.iter().take_while(|v| bound_at[**v].is_some()).count();
            if vars[split..].iter().any(|v| bound_at[*v].is_some()) {
                // A bound variable after an unbound one: the trie order
                // cannot consume it as a key — non-prefix body.
                return Ok(None);
            }
            if split > 0 {
                let probe = FjSubAtom {
                    input_idx: i,
                    var_positions: vars[..split].to_vec(),
                };
                if nodes.is_empty() {
                    return Ok(None);
                }
                let target = vars[..split]
                    .iter()
                    .map(|v| bound_at[*v].expect("prefix vars are bound"))
                    .max()
                    .expect("split > 0");
                nodes[target].probes.push(probe);
            }
            if split < vars.len() {
                let cover_vars = vars[split..].to_vec();
                let mut seen = HashSet::new();
                if !cover_vars.iter().all(|v| seen.insert(*v)) {
                    return Ok(None);
                }
                let k = nodes.len();
                for v in &cover_vars {
                    bound_at[*v] = Some(k);
                }
                nodes.push(FjNode {
                    cover: FjSubAtom {
                        input_idx: i,
                        var_positions: cover_vars,
                    },
                    probes: Vec::new(),
                });
            } else if nodes.is_empty() {
                return Ok(None);
            }
        }
        // Head projection: map join-tree output columns (concatenated
        // input columns in slot order) to variable ids.
        let mut col_to_var: Vec<usize> = Vec::new();
        for vars in &atom_vars {
            col_to_var.extend(vars.iter().copied());
        }
        let mut output_vars: Vec<usize> = Vec::with_capacity(output_columns.len());
        for oc in output_columns {
            let ProjectExpr::Column(c) = oc else {
                return Ok(None);
            };
            let Some(v) = col_to_var.get(*c) else {
                return Ok(None);
            };
            output_vars.push(*v);
        }
        let fj_plan = FjPlan {
            num_vars,
            nodes,
            output_vars,
        };
        if self.provider.memory().runtime().is_none() {
            return Ok(None);
        }
        let Some(launch_stream) = self.wcoj_dispatch_stream_or_init() else {
            return Ok(None);
        };
        let outcome = if all_u32 {
            self.provider
                .free_join_execute_u32_recorded(&bufs, &fj_plan, launch_stream)
        } else {
            self.provider
                .free_join_execute_u64_recorded(&bufs, &fj_plan, launch_stream)
        };
        match outcome {
            Ok(buf) => {
                self.free_join_dispatch_count += 1;
                Ok(Some(buf))
            }
            Err(err) => wcoj_decline_on_error(&mut self.wcoj_error_decline_count, "free-join", err),
        }
    }

    /// Factorized Free Join count-by-root: fused dispatch
    /// for `count` aggregates over FreeJoin-marked general multiway
    /// bodies. The plan is derived like [`Self::try_dispatch_free_join`],
    /// with one refinement:
    /// trailing cover variables PRIVATE to their atom (single global
    /// occurrence, not the group key) are left unconsumed — the
    /// engine multiplies their live trie-range lengths instead of
    /// expanding the frontier (the d-representation count). Count
    /// semantics match the unfused pipeline exactly: the lowered
    /// group input is a non-deduplicating projection of the join
    /// output, so both paths count distinct full body bindings.
    /// u32/Symbol width only (the recorded groupby's engine-wide key
    /// support); every decline silently leaves the unfused path to
    /// run.
    fn try_dispatch_free_join_count(
        &mut self,
        node: &RirNode,
        group_cols: &[ProjectExpr],
    ) -> Result<Option<CudaBuffer>> {
        use xlog_cuda::provider::{FjNode, FjPlan, FjSubAtom};

        if free_join_disabled()? {
            return Ok(None);
        }
        let RirNode::MultiWayJoin {
            inputs,
            slot_vars,
            plan,
            ..
        } = node
        else {
            return Ok(None);
        };
        if !matches!(plan, Some(MultiwayPlan::FreeJoin)) {
            return Ok(None);
        }
        if inputs.len() < 3 {
            return Ok(None);
        }
        let mut bufs: Vec<&CudaBuffer> = Vec::with_capacity(inputs.len());
        for input in inputs {
            let RirNode::Scan { rel } = input else {
                return Ok(None);
            };
            let name = match self.get_rel_name(*rel) {
                Some(s) => s.to_string(),
                None => return Ok(None),
            };
            let Some(buf) = self.store.get(&name) else {
                return Ok(None);
            };
            let four_byte = (0..buf.arity()).all(|i| {
                matches!(
                    buf.schema().column_type(i),
                    Some(ScalarType::U32 | ScalarType::Symbol)
                )
            });
            if !four_byte {
                return Ok(None);
            }
            bufs.push(buf);
        }
        // Dense variable ids (same scheme as the materialize
        // dispatcher).
        let mut class_to_var: Vec<u32> = Vec::new();
        let mut dense = |class: u32| -> usize {
            match class_to_var.iter().position(|c| *c == class) {
                Some(i) => i,
                None => {
                    class_to_var.push(class);
                    class_to_var.len() - 1
                }
            }
        };
        let mut atom_vars: Vec<Vec<usize>> = Vec::with_capacity(slot_vars.len());
        for (i, cols) in slot_vars.iter().enumerate() {
            if cols.len() != bufs[i].arity() {
                return Ok(None);
            }
            let mut vars = Vec::with_capacity(cols.len());
            for c in cols {
                let Some(class) = c else { return Ok(None) };
                vars.push(dense(*class));
            }
            atom_vars.push(vars);
        }
        let num_vars = class_to_var.len();
        // Group key: the group projection's column 0 through the
        // concatenated-inputs column space (FreeJoin provenance).
        let mut col_to_var: Vec<usize> = Vec::new();
        for vars in &atom_vars {
            col_to_var.extend(vars.iter().copied());
        }
        let Some(ProjectExpr::Column(key_col)) = group_cols.first() else {
            return Ok(None);
        };
        let Some(&group_var) = col_to_var.get(*key_col) else {
            return Ok(None);
        };
        // Variable occurrence counts: single-occurrence variables are
        // private to their atom and (unless they key the group)
        // prunable as trailing covers.
        let mut occurrences = vec![0usize; num_vars];
        for vars in &atom_vars {
            for &v in vars {
                occurrences[v] += 1;
            }
        }
        // binary2fj with trailing-private pruning.
        let mut bound_at: Vec<Option<usize>> = vec![None; num_vars];
        let mut nodes: Vec<FjNode> = Vec::new();
        for (i, vars) in atom_vars.iter().enumerate() {
            let split = vars.iter().take_while(|v| bound_at[**v].is_some()).count();
            if vars[split..].iter().any(|v| bound_at[*v].is_some()) {
                // Non-prefix body (see the materialize dispatcher).
                return Ok(None);
            }
            let mut keep_end = vars.len();
            while keep_end > split {
                let v = vars[keep_end - 1];
                if occurrences[v] == 1 && v != group_var {
                    keep_end -= 1;
                } else {
                    break;
                }
            }
            if split == 0 && keep_end == 0 {
                // Fully-private atom: nothing binds or probes it
                // (cannot arise from the promoter — keyless joins
                // are rejected there — but decline defensively).
                return Ok(None);
            }
            if split > 0 {
                let probe = FjSubAtom {
                    input_idx: i,
                    var_positions: vars[..split].to_vec(),
                };
                if nodes.is_empty() {
                    return Ok(None);
                }
                let target = vars[..split]
                    .iter()
                    .map(|v| bound_at[*v].expect("prefix vars are bound"))
                    .max()
                    .expect("split > 0");
                nodes[target].probes.push(probe);
            }
            if split < keep_end {
                let cover_vars = vars[split..keep_end].to_vec();
                let mut seen = HashSet::new();
                if !cover_vars.iter().all(|v| seen.insert(*v)) {
                    return Ok(None);
                }
                let k = nodes.len();
                for v in &cover_vars {
                    bound_at[*v] = Some(k);
                }
                nodes.push(FjNode {
                    cover: FjSubAtom {
                        input_idx: i,
                        var_positions: cover_vars,
                    },
                    probes: Vec::new(),
                });
            } else if nodes.is_empty() {
                return Ok(None);
            }
        }
        if bound_at[group_var].is_none() {
            return Ok(None);
        }
        let fj_plan = FjPlan {
            num_vars,
            nodes,
            output_vars: vec![group_var],
        };
        if self.provider.memory().runtime().is_none() {
            return Ok(None);
        }
        let Some(launch_stream) = self.wcoj_dispatch_stream_or_init() else {
            return Ok(None);
        };
        match self
            .provider
            .free_join_count_by_root_u32_recorded(&bufs, &fj_plan, launch_stream)
        {
            Ok(buf) => {
                self.free_join_dispatch_count += 1;
                self.wcoj_groupby_fusion_dispatch_count += 1;
                Ok(Some(buf))
            }
            Err(err) => {
                wcoj_decline_on_error(&mut self.wcoj_error_decline_count, "free-join-count", err)
            }
        }
    }

    /// Count of times the fused group-by-root count hook produced a
    /// result and the executor installed it (vs. silently falling back to
    /// the materialize+groupby path with the same answer).
    pub fn wcoj_groupby_fusion_dispatch_count(&self) -> u64 {
        self.wcoj_groupby_fusion_dispatch_count
    }

    /// Aggregate-fused WCOJ: dispatch
    /// `GroupBy { Project { MultiWayJoin(triangle) }, key_cols: [0],
    /// aggs: [(_, Count | Sum | Min | Max)] }` through the fused
    /// group-by-root kernels, which never materialize the triangle rows.
    /// The group key column 0 is the variable-order root X in the canonical
    /// triangle output, the condition under which one-pass aggregate
    /// propagation over the variable order is sound. For Sum/Min/Max the
    /// aggregate value column must itself map to a triangle output variable
    /// (Y or Z; plain U32 on the 4-byte path, uniform U64 on the 8-byte
    /// path) so the kernel can read it during traversal; Count ignores the
    /// value column. Every structural mismatch (other
    /// keys/aggs, computed projections, value column not Y/Z or not U32,
    /// non-triangle shape, non-4-byte width, missing buffers/runtime, kill
    /// switch) returns `Ok(None)` — silent decline to the existing
    /// materialize+groupby path. Pipeline errors route through
    /// [`wcoj_decline_on_error`] (counted; `XLOG_WCOJ_STRICT=1` propagates).
    pub(super) fn try_dispatch_wcoj_groupby_root_agg(
        &mut self,
        input: &RirNode,
        key_cols: &[usize],
        aggs: &[(usize, xlog_core::AggOp)],
    ) -> Result<Option<CudaBuffer>> {
        use xlog_core::AggOp;
        if wcoj_groupby_fusion_disabled()? {
            return Ok(None);
        }
        if key_cols != [0] {
            return Ok(None);
        }
        if aggs.len() != 1 {
            return Ok(None);
        }
        let (agg_col, agg_op) = aggs[0];
        if !matches!(agg_op, AggOp::Count | AggOp::Sum | AggOp::Min | AggOp::Max) {
            return Ok(None);
        }
        let RirNode::Project {
            input: multiway,
            columns,
        } = input
        else {
            return Ok(None);
        };
        // The group projection must contain only plain column references.
        if columns.is_empty() || !columns.iter().all(|c| matches!(c, ProjectExpr::Column(_))) {
            return Ok(None);
        }
        // Triangle and 4-cycle place the variable-order root at output
        // position 0 by construction, so their group key must be
        // Column(0). The K-clique root is plan-dependent; its branch
        // validates the planned root itself.
        let key_is_col0 = matches!(columns[0], ProjectExpr::Column(0));
        // For value-reading aggregates the value column must map to a
        // non-key join output variable the per-shape kernel can see
        // (triangle: Y/Z; 4-cycle: X/Y/Z). Resolve the raw output column
        // here (the key itself and non-column refs decline); the
        // per-shape mapping happens after shape match. Count never reads
        // the value column, so any pass-through value columns are
        // admissible.
        let agg_value_col = if matches!(agg_op, AggOp::Count) {
            None
        } else {
            match columns.get(agg_col) {
                Some(ProjectExpr::Column(c)) if *c >= 1 => Some(*c),
                _ => return Ok(None),
            }
        };
        let Some(matched) = match_multiway_triangle(multiway) else {
            // 4-cycle sibling of the triangle fusion (count + sum/min/max).
            // The 4-cycle root is output column 0 by
            // construction, so gate on the key here like the triangle.
            if key_is_col0 {
                if let Some(buf) =
                    self.try_dispatch_wcoj_groupby_root_agg_4cycle(multiway, agg_op, agg_value_col)?
                {
                    return Ok(Some(buf));
                }
            }
            // K-clique (K = 5, 6) count sibling. The clique root is
            // plan-dependent, so the helper validates the group key against
            // the planned root itself instead of key_is_col0. Count-only
            // (no fused clique sum/min/max kernels).
            if !matches!(agg_op, AggOp::Count) {
                return Ok(None);
            }
            if let Some(buf) =
                self.try_dispatch_wcoj_groupby_root_count_clique(multiway, columns)?
            {
                return Ok(Some(buf));
            }
            // Factorized Free Join count-by-root for
            // FreeJoin-marked general multiway bodies (any shape the
            // dedicated fused kernels above declined).
            return self.try_dispatch_free_join_count(multiway, columns);
        };
        // Triangle output space: col 1 = Y, col 2 = Z. Anything else
        // (e.g. an out-of-range ref) declines.
        let agg_value = match agg_value_col {
            None => None,
            Some(1) => Some(WcojRootAggValue::Y),
            Some(2) => Some(WcojRootAggValue::Z),
            Some(_) => return Ok(None),
        };
        if !key_is_col0 {
            return Ok(None);
        }
        let name_xy = match self.get_rel_name(matched.rel_xy) {
            Some(s) => s.to_string(),
            None => return Ok(None),
        };
        let name_yz = match self.get_rel_name(matched.rel_yz) {
            Some(s) => s.to_string(),
            None => return Ok(None),
        };
        let name_xz = match self.get_rel_name(matched.rel_xz) {
            Some(s) => s.to_string(),
            None => return Ok(None),
        };
        let buf_xy = match self.store.get(&name_xy) {
            Some(b) => b,
            None => return Ok(None),
        };
        let buf_yz = match self.store.get(&name_yz) {
            Some(b) => b,
            None => return Ok(None),
        };
        let buf_xz = match self.store.get(&name_xz) {
            Some(b) => b,
            None => return Ok(None),
        };
        let width = match (
            classify_two_col_wcoj_width(buf_xy),
            classify_two_col_wcoj_width(buf_yz),
            classify_two_col_wcoj_width(buf_xz),
        ) {
            (
                Some(WcojKeyWidth::FourByte),
                Some(WcojKeyWidth::FourByte),
                Some(WcojKeyWidth::FourByte),
            ) => WcojKeyWidth::FourByte,
            (
                Some(WcojKeyWidth::EightByte),
                Some(WcojKeyWidth::EightByte),
                Some(WcojKeyWidth::EightByte),
            ) => WcojKeyWidth::EightByte,
            _ => return Ok(None),
        };
        // Fail-open cost-model loss veto: decline the FUSED triangle
        // aggregate to the unfused materialize+groupby only when the cost
        // model has stats AND the triangle is provably small — the
        // small-case the base triangle cost model already declines, which
        // the fused path otherwise bypasses. Fail-open: stats absent / any
        // large input → fuse (every measured fused-aggregate win preserved).
        // The rarer
        // fused 4-cycle/K-clique sub-paths inherit their base shapes'
        // gating posture and are not separately vetoed here.
        {
            let slot_rels = [matched.rel_xy, matched.rel_yz, matched.rel_xz];
            let model = super::wcoj_cost_model::build_wcoj_cost_model(&self.config);
            let ctx = super::wcoj_cost_model::WcojDispatchCtx {
                stats: &self.stats,
                slot_rels: &slot_rels,
            };
            if model.factorized_loss_veto(&ctx) {
                return Ok(None);
            }
        }
        // Sum/Min/Max are arithmetic: on the 4-byte path the columns
        // supplying the value must be plain U32 (Symbol ids are not
        // summable/orderable data — and the unfused groupby rejects Symbol
        // values too, so declining keeps both paths aligned). On the
        // 8-byte path the width classifier already guarantees uniform U64
        // columns, which the u64 fused kernels consume directly.
        if matches!(width, WcojKeyWidth::FourByte) {
            match agg_value {
                Some(WcojRootAggValue::Y)
                    if buf_xy.schema().column_type(1) != Some(xlog_core::ScalarType::U32) =>
                {
                    return Ok(None);
                }
                Some(WcojRootAggValue::Z)
                    if buf_yz.schema().column_type(1) != Some(xlog_core::ScalarType::U32)
                        || buf_xz.schema().column_type(1) != Some(xlog_core::ScalarType::U32) =>
                {
                    return Ok(None);
                }
                Some(_) | None => {}
            }
        }
        if self.provider.memory().runtime().is_none() {
            return Ok(None);
        }
        let Some(launch_stream) = self.wcoj_dispatch_stream_or_init() else {
            return Ok(None);
        };
        let result = match (agg_value, width) {
            (None, WcojKeyWidth::FourByte) => {
                self.provider.wcoj_triangle_groupby_root_count_u32_recorded(
                    buf_xy,
                    buf_yz,
                    buf_xz,
                    wcoj_block_work_unit(),
                    launch_stream,
                )
            }
            (None, WcojKeyWidth::EightByte) => {
                self.provider.wcoj_triangle_groupby_root_count_u64_recorded(
                    buf_xy,
                    buf_yz,
                    buf_xz,
                    wcoj_block_work_unit(),
                    launch_stream,
                )
            }
            (Some(value), WcojKeyWidth::FourByte) => {
                self.provider.wcoj_triangle_groupby_root_agg_u32_recorded(
                    buf_xy,
                    buf_yz,
                    buf_xz,
                    agg_op,
                    value,
                    wcoj_block_work_unit(),
                    launch_stream,
                )
            }
            // U64-key sum/min/max through the u64 fused
            // kernels (value columns are uniform U64 by classification).
            (Some(value), WcojKeyWidth::EightByte) => {
                self.provider.wcoj_triangle_groupby_root_agg_u64_recorded(
                    buf_xy,
                    buf_yz,
                    buf_xz,
                    agg_op,
                    value,
                    wcoj_block_work_unit(),
                    launch_stream,
                )
            }
        };
        match result {
            Ok(buf) => {
                self.wcoj_groupby_fusion_dispatch_count += 1;
                Ok(Some(buf))
            }
            Err(err) => {
                wcoj_decline_on_error(&mut self.wcoj_error_decline_count, "groupby-fusion", err)
            }
        }
    }

    /// Aggregate-fused WCOJ, 4-cycle: dispatch the inner
    /// `MultiWayJoin(4-cycle)` of a count/sum/min/max-by-root aggregate
    /// through the fused group-by-root kernels, which never materialize
    /// the 4-cycle rows. Both accepted `output_columns` layouts place the
    /// variable-order root W at output position 0, so the caller's
    /// `key_cols == [0]` + `columns[0] == Column(0)` checks pin the group
    /// key to W — the soundness condition for one-pass aggregate
    /// propagation.
    ///
    /// Gating decision: the fused path
    /// mirrors the triangle fusion — enabled by default behind the shared
    /// `XLOG_DISABLE_WCOJ_GROUPBY_FUSION` kill switch (checked by the
    /// caller). The `XLOG_USE_WCOJ_4CYCLE*` gates govern only the
    /// NON-aggregate 4-cycle materialize dispatch (opt-in pending its own
    /// default-on evidence); they are intentionally not consulted here,
    /// because a declined or kill-switched fusion falls back to that
    /// independently-gated path (default: embedded binary fallback).
    ///
    /// Value-column mapping (same rules as the triangle): for
    /// Sum/Min/Max the aggregate value must map to a 4-cycle output
    /// variable the kernel can read during traversal — X (col 1, from
    /// e1.col1), Y (col 2, from e2.col1) or Z (col 3, from e3.col1) —
    /// with plain U32 type. Symbol values decline (the unfused groupby
    /// rejects them with the same value-type error, so fused and
    /// kill-switch runs fail identically). Count admits any pass-through
    /// value column and, uniquely, uniform U64 keys.
    ///
    /// Sum/Min/Max are 4-byte-only; u64-key 4-cycle sum/min/max fusion is
    /// deferred and declines silently. Pipeline errors route through
    /// [`wcoj_decline_on_error`] (counted; `XLOG_WCOJ_STRICT=1`
    /// propagates).
    fn try_dispatch_wcoj_groupby_root_agg_4cycle(
        &mut self,
        multiway: &RirNode,
        agg_op: xlog_core::AggOp,
        agg_value_col: Option<usize>,
    ) -> Result<Option<CudaBuffer>> {
        use xlog_core::AggOp;
        let Some(matched) = match_multiway_4cycle(multiway) else {
            return Ok(None);
        };
        // 4-cycle output space: col 1 = X, col 2 = Y, col 3 = Z. Anything
        // else (e.g. an out-of-range ref) declines.
        let agg_value = match agg_value_col {
            None => None,
            Some(1) => Some(Wcoj4CycleRootAggValue::X),
            Some(2) => Some(Wcoj4CycleRootAggValue::Y),
            Some(3) => Some(Wcoj4CycleRootAggValue::Z),
            Some(_) => return Ok(None),
        };
        let name_e1 = match self.get_rel_name(matched.rel_e1) {
            Some(s) => s.to_string(),
            None => return Ok(None),
        };
        let name_e2 = match self.get_rel_name(matched.rel_e2) {
            Some(s) => s.to_string(),
            None => return Ok(None),
        };
        let name_e3 = match self.get_rel_name(matched.rel_e3) {
            Some(s) => s.to_string(),
            None => return Ok(None),
        };
        let name_e4 = match self.get_rel_name(matched.rel_e4) {
            Some(s) => s.to_string(),
            None => return Ok(None),
        };
        let buf_e1 = match self.store.get(&name_e1) {
            Some(b) => b,
            None => return Ok(None),
        };
        let buf_e2 = match self.store.get(&name_e2) {
            Some(b) => b,
            None => return Ok(None),
        };
        let buf_e3 = match self.store.get(&name_e3) {
            Some(b) => b,
            None => return Ok(None),
        };
        let buf_e4 = match self.store.get(&name_e4) {
            Some(b) => b,
            None => return Ok(None),
        };
        let width = match (
            classify_two_col_wcoj_width(buf_e1),
            classify_two_col_wcoj_width(buf_e2),
            classify_two_col_wcoj_width(buf_e3),
            classify_two_col_wcoj_width(buf_e4),
        ) {
            (
                Some(WcojKeyWidth::FourByte),
                Some(WcojKeyWidth::FourByte),
                Some(WcojKeyWidth::FourByte),
                Some(WcojKeyWidth::FourByte),
            ) => WcojKeyWidth::FourByte,
            (
                Some(WcojKeyWidth::EightByte),
                Some(WcojKeyWidth::EightByte),
                Some(WcojKeyWidth::EightByte),
                Some(WcojKeyWidth::EightByte),
            ) => WcojKeyWidth::EightByte,
            _ => return Ok(None),
        };
        // Sum/Min/Max are 4-byte-only (u64-key 4-cycle sum/min/max fusion
        // is deferred and declines to materialize+groupby).
        if agg_value.is_some() && width != WcojKeyWidth::FourByte {
            return Ok(None);
        }
        // Sum/Min/Max are arithmetic: the column supplying the value must
        // be plain U32 (Symbol ids are not summable/orderable data — and
        // the unfused groupby rejects Symbol values too, so declining
        // keeps both paths aligned). The checked column matches the
        // materialized (W, X, Y, Z) baseline schema's type source
        // (`build_4cycle_head_schema`): X from e1.col1, Y from e2.col1,
        // Z from e3.col1.
        let value_source = match agg_value {
            None => None,
            Some(Wcoj4CycleRootAggValue::X) => Some(buf_e1),
            Some(Wcoj4CycleRootAggValue::Y) => Some(buf_e2),
            Some(Wcoj4CycleRootAggValue::Z) => Some(buf_e3),
        };
        if let Some(src) = value_source {
            if src.schema().column_type(1) != Some(xlog_core::ScalarType::U32) {
                return Ok(None);
            }
        }
        if self.provider.memory().runtime().is_none() {
            return Ok(None);
        }
        let Some(launch_stream) = self.wcoj_dispatch_stream_or_init() else {
            return Ok(None);
        };
        debug_assert!(
            agg_value.is_some() || matches!(agg_op, AggOp::Count),
            "non-Count aggregates resolve a value column above"
        );
        let result = match (agg_value, width) {
            (None, WcojKeyWidth::FourByte) => {
                self.provider.wcoj_4cycle_groupby_root_count_u32_recorded(
                    buf_e1,
                    buf_e2,
                    buf_e3,
                    buf_e4,
                    wcoj_block_work_unit(),
                    launch_stream,
                )
            }
            // U64-key count through the metadata-driven
            // segment reduction (the recorded groupby is U32/Symbol-key
            // only).
            (None, WcojKeyWidth::EightByte) => {
                self.provider.wcoj_4cycle_groupby_root_count_u64_recorded(
                    buf_e1,
                    buf_e2,
                    buf_e3,
                    buf_e4,
                    wcoj_block_work_unit(),
                    launch_stream,
                )
            }
            (Some(value), _) => self.provider.wcoj_4cycle_groupby_root_agg_u32_recorded(
                buf_e1,
                buf_e2,
                buf_e3,
                buf_e4,
                agg_op,
                value,
                wcoj_block_work_unit(),
                launch_stream,
            ),
        };
        match result {
            Ok(buf) => {
                self.wcoj_groupby_fusion_dispatch_count += 1;
                Ok(Some(buf))
            }
            Err(err) => wcoj_decline_on_error(
                &mut self.wcoj_error_decline_count,
                "groupby-fusion-4cycle",
                err,
            ),
        }
    }

    /// Count of times the WCOJ 4-cycle hook
    /// produced a result and the executor installed it. Tracked
    /// separately from triangle so tests can pin which shape
    /// dispatched.
    pub fn wcoj_4cycle_dispatch_count(&self) -> u64 {
        self.wcoj_4cycle_dispatch_count
    }

    /// Count of times a two-atom `ChainJoin` routed through the chain
    /// dispatcher instead of the embedded binary fallback.
    pub fn chain_dispatch_count(&self) -> u64 {
        self.chain_dispatch_count
    }

    /// Count of times `execute_join` routed an inner-join
    /// to the nested-loop provider entry point because the
    /// eligibility predicate + Cartesian-product threshold both
    /// held. Tests use this counter to assert that the nested-loop path
    /// actually fired vs. silently falling back to hash with the
    /// same answer.
    pub fn nested_loop_dispatch_count(&self) -> u64 {
        self.nested_loop_dispatch_count
    }

    /// ChainJoin dispatch. Shape match is done on the production
    /// `ChainJoin` emitted by the promoter.
    ///
    /// Route order:
    ///   1. sorted eligible U32/Symbol inputs -> sort-merge
    ///   2. threshold eligible U32/Symbol inputs -> nested loop
    ///   3. otherwise -> existing hash_join_v2 provider path
    ///
    /// The final projection uses the captured `output_columns`, so
    /// row semantics match `MultiWayJoin.fallback`.
    pub(super) fn try_dispatch_chain_on_body(
        &mut self,
        body: &RirNode,
    ) -> Result<Option<CudaBuffer>> {
        if !chain_dispatch_enabled()? {
            return Ok(None);
        }
        let Some(matched) = match_chain_join(body) else {
            return Ok(None);
        };

        let name_left = match self.get_rel_name(matched.rel_left) {
            Some(s) => s.to_string(),
            None => return Ok(None),
        };
        let name_right = match self.get_rel_name(matched.rel_right) {
            Some(s) => s.to_string(),
            None => return Ok(None),
        };
        let left = match self.store.get(&name_left) {
            Some(buf) => buf,
            None => return Ok(None),
        };
        let right = match self.store.get(&name_right) {
            Some(buf) => buf,
            None => return Ok(None),
        };

        let num_left = self.provider.device_row_count(left)? as u64;
        let num_right = self.provider.device_row_count(right)? as u64;
        let in_threshold = num_left
            .checked_mul(num_right)
            .map(|p| p <= NESTED_LOOP_TOTAL_THRESHOLD)
            .unwrap_or(false);
        let four_byte = matches!(
            classify_two_col_wcoj_width(left),
            Some(WcojKeyWidth::FourByte)
        ) && matches!(
            classify_two_col_wcoj_width(right),
            Some(WcojKeyWidth::FourByte)
        );

        let mut used_nested_loop = false;
        let joined = if four_byte {
            let left_sorted = self
                .provider
                .is_sorted_ascending_u32(left, matched.left_key)
                .unwrap_or(false);
            let right_sorted = self
                .provider
                .is_sorted_ascending_u32(right, matched.right_key)
                .unwrap_or(false);
            if left_sorted && right_sorted {
                if in_threshold {
                    self.provider.sort_merge_join_v2_inner_u32_1key(
                        left,
                        right,
                        matched.left_key,
                        matched.right_key,
                    )
                } else {
                    let capacity = usize::try_from(num_left.min(num_right)).unwrap_or(usize::MAX);
                    self.provider.sort_merge_join_v2_inner_u32_1key_bounded(
                        left,
                        right,
                        matched.left_key,
                        matched.right_key,
                        capacity,
                    )
                }
            } else if in_threshold {
                used_nested_loop = true;
                self.provider.nested_loop_join_v2_inner_u32_1key(
                    left,
                    right,
                    matched.left_key,
                    matched.right_key,
                )
            } else {
                self.provider.hash_join_v2(
                    left,
                    right,
                    &[matched.left_key],
                    &[matched.right_key],
                    CudaJoinType::Inner,
                )
            }
        } else {
            self.provider.hash_join_v2(
                left,
                right,
                &[matched.left_key],
                &[matched.right_key],
                CudaJoinType::Inner,
            )
        };

        let joined = match joined {
            Ok(buf) => buf,
            Err(err) => {
                record_chain_fallback_equivalents(
                    body,
                    false,
                    &mut self.chain_fallback_scan_equivalents,
                    &mut self.chain_fallback_filter_equivalents,
                );
                return wcoj_decline_on_error(
                    &mut self.wcoj_error_decline_count,
                    "chain-join",
                    err,
                );
            }
        };
        let projected = match self.execute_project(&joined, &matched.output_columns) {
            Ok(buf) => buf,
            Err(err) => {
                record_chain_fallback_equivalents(
                    body,
                    false,
                    &mut self.chain_fallback_scan_equivalents,
                    &mut self.chain_fallback_filter_equivalents,
                );
                return wcoj_decline_on_error(
                    &mut self.wcoj_error_decline_count,
                    "chain-join-project",
                    err,
                );
            }
        };
        self.stats.record_join_result(
            matched.rel_left,
            matched.rel_right,
            vec![matched.left_key],
            vec![matched.right_key],
            num_left.saturating_mul(num_right),
            joined.num_rows(),
        );
        if used_nested_loop {
            self.nested_loop_dispatch_count += 1;
        }
        record_chain_fallback_equivalents(
            body,
            true,
            &mut self.chain_fallback_scan_equivalents,
            &mut self.chain_fallback_filter_equivalents,
        );
        self.chain_dispatch_count += 1;
        Ok(Some(projected))
    }

    /// Try to dispatch a non-recursive rule
    /// through the GPU 4-cycle WCOJ kernel.
    ///
    /// Decision tree (highest → lowest):
    ///   1. Hard kill switch (`wcoj_4cycle_dispatch_disabled` /
    ///      `XLOG_DISABLE_WCOJ_4CYCLE=1`) → no dispatch.
    ///   2. Force gate (`wcoj_4cycle_dispatch=Some(true)` /
    ///      `XLOG_USE_WCOJ_4CYCLE=1`) → kernel runs.
    ///   3. Force-Some(false) → no dispatch.
    ///   4. Stats opt-in (config / env, default off) →
    ///      cardinality model decides whether the kernel runs.
    ///
    /// Returns `Ok(Some(buffer))` on dispatch; `Ok(None)`
    /// silently otherwise. The caller installs the buffer or
    /// descends into `MultiWayJoin.fallback`.
    pub(super) fn try_dispatch_wcoj_4cycle(
        &mut self,
        rule: &CompiledRule,
    ) -> Result<Option<CudaBuffer>> {
        // Body-keyed entry. Rule-keyed callers stay
        // byte-identical via this thin wrapper.
        self.try_dispatch_wcoj_4cycle_on_body(&rule.body)
    }

    /// Body-keyed entry point: same gate / pattern-match / dispatch
    /// logic as `try_dispatch_wcoj_4cycle`, keyed on `body` rather
    /// than `&CompiledRule`. See
    /// `try_dispatch_wcoj_triangle_on_body` for the rationale.
    pub(super) fn try_dispatch_wcoj_4cycle_on_body(
        &mut self,
        body: &RirNode,
    ) -> Result<Option<CudaBuffer>> {
        // 1. Kill switch.
        if wcoj_4cycle_disabled(self.config.wcoj_4cycle_dispatch_disabled)? {
            return Ok(None);
        }
        // 2. Force gate.
        let force_override = self.config.wcoj_4cycle_dispatch;
        let force_on = wcoj_4cycle_gate_enabled(force_override)?;
        let mode = if force_on {
            DispatchMode::Force
        } else {
            // Force-Some(false) is explicit off — adaptive does
            // NOT resurrect it.
            if matches!(force_override, Some(false)) {
                return Ok(None);
            }
            let adaptive_override = self.config.wcoj_4cycle_dispatch_adaptive;
            if wcoj_4cycle_adaptive_enabled(adaptive_override)? {
                DispatchMode::CostModel
            } else {
                return Ok(None);
            }
        };

        // 3. Match the canonical 4-cycle MultiWayJoin.
        let Some(matched) = match_multiway_4cycle(body) else {
            return Ok(None);
        };

        // 4. Resolve rel IDs to predicate names.
        let name_e1 = match self.get_rel_name(matched.rel_e1) {
            Some(s) => s.to_string(),
            None => return Ok(None),
        };
        let name_e2 = match self.get_rel_name(matched.rel_e2) {
            Some(s) => s.to_string(),
            None => return Ok(None),
        };
        let name_e3 = match self.get_rel_name(matched.rel_e3) {
            Some(s) => s.to_string(),
            None => return Ok(None),
        };
        let name_e4 = match self.get_rel_name(matched.rel_e4) {
            Some(s) => s.to_string(),
            None => return Ok(None),
        };

        // 5. Look up input buffers + classify their key widths.
        // All four slots must share the same width.
        let buf_e1 = match self.store.get(&name_e1) {
            Some(b) => b,
            None => return Ok(None),
        };
        let buf_e2 = match self.store.get(&name_e2) {
            Some(b) => b,
            None => return Ok(None),
        };
        let buf_e3 = match self.store.get(&name_e3) {
            Some(b) => b,
            None => return Ok(None),
        };
        let buf_e4 = match self.store.get(&name_e4) {
            Some(b) => b,
            None => return Ok(None),
        };
        let width = match (
            classify_two_col_wcoj_width(buf_e1),
            classify_two_col_wcoj_width(buf_e2),
            classify_two_col_wcoj_width(buf_e3),
            classify_two_col_wcoj_width(buf_e4),
        ) {
            (Some(a), Some(b), Some(c), Some(d)) if a == b && b == c && c == d => a,
            _ => return Ok(None),
        };

        // 6. Resolve the cached WCOJ launch stream (shared with
        // triangle dispatch; the stream resolver is now
        // shape-agnostic).
        if self.provider.memory().runtime().is_none() {
            return Ok(None);
        }
        let launch_stream = match self.wcoj_dispatch_stream_or_init() {
            Some(s) => s,
            None => return Ok(None),
        };

        // 7. Stats-backed mode: route the decision through
        // the cardinality WCOJ cost model.
        if mode == DispatchMode::CostModel {
            // Factory selects per RuntimeConfig precedence.
            let model = super::wcoj_cost_model::build_wcoj_cost_model(&self.config);
            let slot_rels = [
                matched.rel_e1,
                matched.rel_e2,
                matched.rel_e3,
                matched.rel_e4,
            ];
            let ctx = super::wcoj_cost_model::WcojDispatchCtx {
                stats: &self.stats,
                slot_rels: &slot_rels,
            };
            let dispatch = model.should_dispatch_4cycle(&ctx);
            if !dispatch {
                return Ok(None);
            }
        }

        // Extract var_order. None preserves default-leader dispatch
        // bit-identically.
        let var_order_opt: Option<&VariableOrder> = match body {
            RirNode::MultiWayJoin { var_order, .. } => var_order.as_ref(),
            _ => None,
        };

        // 8. Run layout (4× per slot) + 4-cycle kernel. Failure
        // → silent fallback per slice contract.
        let dispatch_result = self.run_wcoj_4cycle_pipeline(
            buf_e1,
            buf_e2,
            buf_e3,
            buf_e4,
            launch_stream,
            width,
            var_order_opt,
        );
        match dispatch_result {
            Ok(buf) => {
                // Record observed selectivity.
                // The (rel_a, rel_b, left_keys, right_keys)
                // pair is derived from `var_order_opt` via
                // `feedback_pair_from_var_order`:
                //   * `var_order = None` (default config) →
                //     canonical `(rel_e1, rel_e2)` keys
                //     `[1]/[0]`.
                //   * `var_order = Some(_)` (non-default leader) →
                //     rotated pair from the feedback table. 4-cycle is
                //     rotation-only (every cycle edge is
                //     `[1]/[0]` in canonical layout), so the
                //     keys stay `[1]/[0]` while the pair
                //     itself rotates.
                let output_rows = Self::wcoj_output_rows(&buf);
                let slot_rels = [
                    matched.rel_e1,
                    matched.rel_e2,
                    matched.rel_e3,
                    matched.rel_e4,
                ];
                self.record_wcoj_feedback(&slot_rels, var_order_opt, output_rows);
                self.wcoj_4cycle_dispatch_count += 1;
                Ok(Some(buf))
            }
            Err(err) => wcoj_decline_on_error(&mut self.wcoj_error_decline_count, "4-cycle", err),
        }
    }

    /// Inner pipeline for 4-cycle: 4× layout construction + kernel.
    #[expect(
        clippy::too_many_arguments,
        reason = "four-cycle dispatch keeps four typed edge inputs plus stream, width, and variable order explicit"
    )]
    fn run_wcoj_4cycle_pipeline(
        &self,
        buf_e1: &CudaBuffer,
        buf_e2: &CudaBuffer,
        buf_e3: &CudaBuffer,
        buf_e4: &CudaBuffer,
        launch_stream: StreamId,
        width: WcojKeyWidth,
        var_order: Option<&VariableOrder>,
    ) -> Result<CudaBuffer> {
        if let Some(vo) = var_order {
            return self.run_wcoj_4cycle_pipeline_with_leader_order(
                buf_e1,
                buf_e2,
                buf_e3,
                buf_e4,
                launch_stream,
                width,
                vo,
            );
        }
        match width {
            WcojKeyWidth::FourByte => {
                let layout_e1 = self
                    .provider
                    .wcoj_layout_u32_recorded(buf_e1, launch_stream)?;
                let layout_e2 = self
                    .provider
                    .wcoj_layout_u32_recorded(buf_e2, launch_stream)?;
                let layout_e3 = self
                    .provider
                    .wcoj_layout_u32_recorded(buf_e3, launch_stream)?;
                let layout_e4 = self
                    .provider
                    .wcoj_layout_u32_recorded(buf_e4, launch_stream)?;
                self.provider.wcoj_4cycle_u32_recorded(
                    &layout_e1,
                    &layout_e2,
                    &layout_e3,
                    &layout_e4,
                    launch_stream,
                )
            }
            WcojKeyWidth::EightByte => {
                let layout_e1 = self
                    .provider
                    .wcoj_layout_u64_recorded(buf_e1, launch_stream)?;
                let layout_e2 = self
                    .provider
                    .wcoj_layout_u64_recorded(buf_e2, launch_stream)?;
                let layout_e3 = self
                    .provider
                    .wcoj_layout_u64_recorded(buf_e3, launch_stream)?;
                let layout_e4 = self
                    .provider
                    .wcoj_layout_u64_recorded(buf_e4, launch_stream)?;
                self.provider.wcoj_4cycle_u64_recorded(
                    &layout_e1,
                    &layout_e2,
                    &layout_e3,
                    &layout_e4,
                    launch_stream,
                )
            }
        }
    }

    /// Pipeline for non-default 4-cycle leaders. All
    /// 4-cycle leaders are rotation-only (no col-swap entries
    /// in `lookup_perms`); kernel emits in `(a, b, c, d)` order
    /// per the rotated leader; final projection helper remaps
    /// to canonical `(W, X, Y, Z)` head order.
    #[expect(
        clippy::too_many_arguments,
        reason = "leader-ordered four-cycle dispatch keeps four canonical inputs and the exact launch contract explicit"
    )]
    fn run_wcoj_4cycle_pipeline_with_leader_order(
        &self,
        buf_e1: &CudaBuffer,
        buf_e2: &CudaBuffer,
        buf_e3: &CudaBuffer,
        buf_e4: &CudaBuffer,
        launch_stream: StreamId,
        width: WcojKeyWidth,
        var_order: &VariableOrder,
    ) -> Result<CudaBuffer> {
        let canonical: [&CudaBuffer; 4] = [buf_e1, buf_e2, buf_e3, buf_e4];
        let slot_inputs = self.prepare_leader_inputs(&canonical, var_order, launch_stream)?;
        if slot_inputs.len() != 4 {
            return Err(xlog_core::XlogError::Kernel(
                "run_wcoj_4cycle_pipeline_with_leader_order: prepare_leader_inputs must return 4 slots"
                    .to_string(),
            ));
        }

        let head_schema = build_4cycle_head_schema(buf_e1, buf_e2, buf_e3)?;
        let perm = perm_indices_from_kernel_output_cols(&var_order.kernel_output_cols)?;

        let kernel_out: CudaBuffer = match width {
            WcojKeyWidth::FourByte => {
                let l0 = self
                    .provider
                    .wcoj_layout_u32_recorded(&slot_inputs[0], launch_stream)?;
                let l1 = self
                    .provider
                    .wcoj_layout_u32_recorded(&slot_inputs[1], launch_stream)?;
                let l2 = self
                    .provider
                    .wcoj_layout_u32_recorded(&slot_inputs[2], launch_stream)?;
                let l3 = self
                    .provider
                    .wcoj_layout_u32_recorded(&slot_inputs[3], launch_stream)?;
                self.provider
                    .wcoj_4cycle_u32_recorded(&l0, &l1, &l2, &l3, launch_stream)?
            }
            WcojKeyWidth::EightByte => {
                let l0 = self
                    .provider
                    .wcoj_layout_u64_recorded(&slot_inputs[0], launch_stream)?;
                let l1 = self
                    .provider
                    .wcoj_layout_u64_recorded(&slot_inputs[1], launch_stream)?;
                let l2 = self
                    .provider
                    .wcoj_layout_u64_recorded(&slot_inputs[2], launch_stream)?;
                let l3 = self
                    .provider
                    .wcoj_layout_u64_recorded(&slot_inputs[3], launch_stream)?;
                self.provider
                    .wcoj_4cycle_u64_recorded(&l0, &l1, &l2, &l3, launch_stream)?
            }
        };

        self.provider.wcoj_project_output_columns_recorded(
            &kernel_out,
            &perm,
            head_schema,
            launch_stream,
        )
    }

    /// Produce **owned, materialized** kernel slot inputs
    /// from a canonical-order input array and a `VariableOrder`.
    ///
    /// **Public** runtime helper. Production callers are
    /// `run_wcoj_*_pipeline_with_leader_order` (this module); runtime tests
    /// in `crates/xlog-runtime/tests/test_leader_input_permutation_tables.rs` invoke it
    /// directly to assert per-slot schema + content against a CPU
    /// reference. Public visibility is intentional: there is no
    /// other reasonable seam for tests to inspect rotation +
    /// col-swap behavior, and the helper has well-defined
    /// owned-buffer semantics that external callers can rely on.
    ///
    /// Returns a `Vec<CudaBuffer>` of length `canonical.len()` (3
    /// for triangle, 4 for 4-cycle). Slot 0 is the leader; slots
    /// 1.. follow `var_order.lookup_perms[i].input_idx` mapping.
    /// Triangle non-default leaders may col-swap selected slots
    /// per the locked permutation table; 4-cycle is rotation-only
    /// and rejects swap requests with a kernel error.
    ///
    /// Each returned `CudaBuffer` is owned: swapped slots are
    /// DtoD-copied via `wcoj_project_2col_swap_recorded`; non-
    /// swapped slots use the double-swap clone path below to give
    /// every slot a uniform owned-buffer return type.
    ///
    /// **Lifetime contract**: returned buffers are independent of
    /// `canonical[*]`. Callers may pass references through to
    /// `wcoj_layout_*_recorded` without aliasing concerns.
    pub fn prepare_leader_inputs(
        &self,
        canonical: &[&CudaBuffer],
        var_order: &VariableOrder,
        launch_stream: StreamId,
    ) -> Result<Vec<CudaBuffer>> {
        let n = canonical.len();
        if !(n == 3 || n == 4) {
            return Err(xlog_core::XlogError::Kernel(format!(
                "prepare_leader_inputs: canonical inputs must be 3 (triangle) or 4 (4-cycle), got {n}"
            )));
        }
        let leader_idx = var_order.leader_idx as usize;
        if leader_idx >= n {
            return Err(xlog_core::XlogError::Kernel(format!(
                "prepare_leader_inputs: leader_idx {leader_idx} out of range for arity {n}"
            )));
        }
        if var_order.lookup_perms.len() != n - 1 {
            return Err(xlog_core::XlogError::Kernel(format!(
                "prepare_leader_inputs: lookup_perms.len() = {} must equal {} (arity - 1)",
                var_order.lookup_perms.len(),
                n - 1
            )));
        }
        for (slot, lp) in var_order.lookup_perms.iter().enumerate() {
            let input_idx = lp.input_idx as usize;
            if input_idx >= n {
                return Err(xlog_core::XlogError::Kernel(format!(
                    "prepare_leader_inputs: lookup_perms[{slot}].input_idx {input_idx} out of range for arity {n}"
                )));
            }
        }
        // 4-cycle defense: no col-swaps allowed (locked table).
        if n == 4 {
            for lp in &var_order.lookup_perms {
                if lp.swap_cols {
                    return Err(xlog_core::XlogError::Kernel(
                        "prepare_leader_inputs: 4-cycle does not support col-swaps".to_string(),
                    ));
                }
            }
        }

        // Slot 0: clone the leader via the swap helper called twice
        // (cancels out → owned pass-through). The simpler path for
        // production is just passing `canonical[leader_idx]` by
        // reference, but since the production callers consume the
        // returned `Vec<CudaBuffer>` by index, we materialize an
        // owned copy. Triangle leaders never have swap_cols on
        // their own slot; we use `wcoj_project_2col_swap_recorded`
        // twice to produce an owned copy with identical layout.
        //
        // For clarity and to avoid the extra DtoD: leader slot 0 is
        // produced by single swap-twice, lookups by either single
        // swap (when swap_cols) or single swap-twice (when not).
        //
        // Cost: one extra DtoD copy per slot vs. the previous
        // inline-references implementation. The leader-ordered path is opt-in,
        // and the DtoD overhead is small relative to the layout + kernel cost.
        let mut slots: Vec<CudaBuffer> = Vec::with_capacity(n);
        // Slot 0 = leader, no swap.
        slots.push(self.clone_buffer_via_swap(canonical[leader_idx], launch_stream)?);
        for lp in &var_order.lookup_perms {
            let src = canonical[lp.input_idx as usize];
            let buf = if lp.swap_cols {
                self.provider
                    .wcoj_project_2col_swap_recorded(src, launch_stream)?
            } else {
                self.clone_buffer_via_swap(src, launch_stream)?
            };
            slots.push(buf);
        }
        Ok(slots)
    }

    /// Clone a 2-col `CudaBuffer` via a double-swap through the
    /// existing recorded helper. Two swaps cancel — the result is a
    /// fresh owned buffer with the same column order, schema, and
    /// content as `src`. Used by `prepare_leader_inputs` to give
    /// every slot a uniform owned-buffer return type.
    fn clone_buffer_via_swap(
        &self,
        src: &CudaBuffer,
        launch_stream: StreamId,
    ) -> Result<CudaBuffer> {
        let once = self
            .provider
            .wcoj_project_2col_swap_recorded(src, launch_stream)?;
        self.provider
            .wcoj_project_2col_swap_recorded(&once, launch_stream)
    }

    /// Resolve the cached WCOJ launch stream, lazily initializing
    /// it on first call by acquiring one stream from the runtime
    /// pool. Subsequent calls reuse the same stream — mirrors
    /// [`xlog_cuda::CudaKernelProvider::recorded_op_stream`]
    /// (provider/mod.rs).
    ///
    /// **Shared across WCOJ shapes**: triangle
    /// and 4-cycle dispatch both go through this resolver and
    /// reuse the same stream. Renamed from
    /// `wcoj_triangle_stream_or_init` when 4-cycle dispatch
    /// landed.
    ///
    /// Returns `None` only when (a) the manager has no runtime,
    /// or (b) the very first acquisition fails (pool already
    /// at cap from other consumers). After that first success
    /// the cached id keeps resolving for the executor's lifetime.
    pub fn wcoj_dispatch_stream_or_init(&self) -> Option<StreamId> {
        if let Some(s) = self.wcoj_dispatch_stream.get() {
            return Some(*s);
        }
        let runtime = self.provider.memory().runtime()?;
        let stream = runtime.stream_pool().acquire().ok()?;
        let _ = self.wcoj_dispatch_stream.set(stream);
        self.wcoj_dispatch_stream.get().copied()
    }
}

// ===============================================================
// K-clique dispatch (k = 5..8).
//
// Default-dispatch on shape match. No force / kill / adaptive
// knobs.
// Silent fallback to MultiWayJoin.fallback on dispatcher decline
// or kernel error.
//
// Counter accessors are public so xlog-integration
// certs can assert across the crate boundary.
// ===============================================================

impl Executor {
    /// Number of times the WCOJ k=5-clique hook produced a
    /// result and the executor installed it. Counter does NOT
    /// advance on dispatcher decline / kernel-launch failure
    /// (silent fallback to `MultiWayJoin.fallback`).
    pub fn wcoj_clique5_dispatch_count(&self) -> u64 {
        self.wcoj_clique5_dispatch_count
    }

    /// Number of times the WCOJ k=6-clique hook produced
    /// a result. Same observability contract as
    /// `wcoj_clique5_dispatch_count`.
    pub fn wcoj_clique6_dispatch_count(&self) -> u64 {
        self.wcoj_clique6_dispatch_count
    }

    /// Number of times the WCOJ k=7-clique hook produced
    /// a result. Same observability contract as
    /// `wcoj_clique5_dispatch_count`.
    pub fn wcoj_clique7_dispatch_count(&self) -> u64 {
        self.wcoj_clique7_dispatch_count
    }

    /// Number of times the WCOJ k=8-clique hook produced
    /// a result. Same observability contract as
    /// `wcoj_clique5_dispatch_count`.
    pub fn wcoj_clique8_dispatch_count(&self) -> u64 {
        self.wcoj_clique8_dispatch_count
    }

    /// Number of recursive merge
    /// boundaries where K-clique metadata was marked for refresh.
    pub fn kclique_histogram_refresh_count(&self) -> u64 {
        self.kclique_histogram_refresh_count
    }

    /// Cumulative recursive K-clique metadata refresh accounting
    /// time in nanoseconds.
    pub fn kclique_histogram_refresh_nanos(&self) -> u128 {
        self.kclique_histogram_refresh_nanos
    }

    /// Try k=5-clique dispatch. Wrapper for rule-keyed
    /// callers (recursive engine + non-recursive scc).
    pub(super) fn try_dispatch_wcoj_clique5(
        &mut self,
        rule: &CompiledRule,
    ) -> Result<Option<CudaBuffer>> {
        self.try_dispatch_wcoj_clique5_on_body(&rule.body)
    }

    /// Try k=6-clique dispatch.
    pub(super) fn try_dispatch_wcoj_clique6(
        &mut self,
        rule: &CompiledRule,
    ) -> Result<Option<CudaBuffer>> {
        self.try_dispatch_wcoj_clique6_on_body(&rule.body)
    }

    /// Try k=7-clique dispatch.
    pub(super) fn try_dispatch_wcoj_clique7(
        &mut self,
        rule: &CompiledRule,
    ) -> Result<Option<CudaBuffer>> {
        self.try_dispatch_wcoj_clique7_on_body(&rule.body)
    }

    /// Try k=8-clique dispatch.
    pub(super) fn try_dispatch_wcoj_clique8(
        &mut self,
        rule: &CompiledRule,
    ) -> Result<Option<CudaBuffer>> {
        self.try_dispatch_wcoj_clique8_on_body(&rule.body)
    }

    /// Body-keyed k=5-clique dispatch.
    pub(super) fn try_dispatch_wcoj_clique5_on_body(
        &mut self,
        body: &RirNode,
    ) -> Result<Option<CudaBuffer>> {
        self.try_dispatch_wcoj_clique_k_on_body(body, 5)
    }

    /// Body-keyed k=6-clique dispatch.
    pub(super) fn try_dispatch_wcoj_clique6_on_body(
        &mut self,
        body: &RirNode,
    ) -> Result<Option<CudaBuffer>> {
        self.try_dispatch_wcoj_clique_k_on_body(body, 6)
    }

    /// Body-keyed k=7-clique dispatch.
    pub(super) fn try_dispatch_wcoj_clique7_on_body(
        &mut self,
        body: &RirNode,
    ) -> Result<Option<CudaBuffer>> {
        self.try_dispatch_wcoj_clique_k_on_body(body, 7)
    }

    /// Body-keyed k=8-clique dispatch.
    pub(super) fn try_dispatch_wcoj_clique8_on_body(
        &mut self,
        body: &RirNode,
    ) -> Result<Option<CudaBuffer>> {
        self.try_dispatch_wcoj_clique_k_on_body(body, 8)
    }

    /// Generic K-clique dispatch shared by k=5..8
    /// entries. Returns `Ok(Some(buffer))` on dispatch;
    /// `Ok(None)` on decline / fallback.
    fn try_dispatch_wcoj_clique_k_on_body(
        &mut self,
        body: &RirNode,
        k: usize,
    ) -> Result<Option<CudaBuffer>> {
        let expected_edges = k * (k - 1) / 2;
        // 1. Shape match: MultiWayJoin with inputs.len() == C(k, 2).
        let RirNode::MultiWayJoin {
            inputs,
            plan,
            var_order,
            ..
        } = body
        else {
            return Ok(None);
        };
        if matches!(plan, Some(MultiwayPlan::PlannedHashRoute { .. })) {
            return Ok(None);
        }
        if inputs.len() != expected_edges {
            return Ok(None);
        }
        let kclique = match var_order.as_ref().and_then(|order| order.kclique.as_ref()) {
            Some(plan) if usize::from(plan.k) == k => plan,
            _ => return Ok(None),
        };
        // 2. Extract RelIds from each input (must all be Scans).
        let mut rel_ids: Vec<RelId> = Vec::with_capacity(expected_edges);
        for input in inputs {
            let RirNode::Scan { rel } = input else {
                return Ok(None);
            };
            rel_ids.push(*rel);
        }
        // 3. Resolve each rel to a buffer in the relation store.
        let mut raw_bufs: Vec<&CudaBuffer> = Vec::with_capacity(expected_edges);
        for rid in &rel_ids {
            let name = match self.rel_names.get(rid) {
                Some(n) => n.clone(),
                None => return Ok(None),
            };
            match self.store.get(&name) {
                Some(b) => raw_bufs.push(b),
                None => return Ok(None),
            }
        }
        // 4. Acquire dispatch stream.
        let launch_stream = match self.wcoj_dispatch_stream_or_init() {
            Some(s) => s,
            None => return Ok(None),
        };
        // 5. Determine width-class from the first edge's column 0.
        // All edges must share the width-class; provider entries
        // re-validate.
        let first_ty = match raw_bufs[0].schema().column_type(0) {
            Some(t) => t,
            None => return Ok(None),
        };
        let is_u64 = matches!(first_ty, xlog_core::ScalarType::U64);
        let is_4byte = matches!(
            first_ty,
            xlog_core::ScalarType::U32 | xlog_core::ScalarType::Symbol
        );
        if !is_u64 && !is_4byte {
            return Ok(None);
        }
        let Some(plan_params) = kclique_dispatch_params(kclique, k) else {
            return Ok(None);
        };
        let head_schema = match build_kclique_head_schema(&raw_bufs, k) {
            Some(schema) => schema,
            None => return Ok(None),
        };
        let output_perm = match kclique_output_perm(kclique, k) {
            Some(perm) => perm,
            None => return Ok(None),
        };
        // 6. Orient edges according to KCliqueVariableOrder, then
        // layout only the plan-required physical slots through the
        // generic layout-sort helper. Remaining 2-column slots use
        // the narrower WCOJ layout entry, which preserves correctness
        // and can take the sorted-unique fast path.
        let laid_out = match self.orient_and_layout_kclique_edges(
            &raw_bufs,
            &plan_params,
            is_u64,
            launch_stream,
        ) {
            Ok(bufs) => bufs,
            Err(err) => {
                return wcoj_decline_on_error(
                    &mut self.wcoj_error_decline_count,
                    "k-clique-layout",
                    err,
                )
            }
        };
        // 7. Build the slice of buffer references the provider
        // expects.
        let edge_refs: Vec<&CudaBuffer> = laid_out.iter().collect();
        // 8. Dispatch the appropriate provider entry.
        let result = match (k, is_u64) {
            (5, false) => {
                let arr: &[&CudaBuffer; 10] = match edge_refs.as_slice().try_into() {
                    Ok(a) => a,
                    Err(_) => return Ok(None),
                };
                self.provider.wcoj_clique5_u32_recorded_planned(
                    arr,
                    plan_params.leader_edge_idx,
                    &plan_params.edge_order,
                    &plan_params.iteration_order,
                    launch_stream,
                )
            }
            (5, true) => {
                let arr: &[&CudaBuffer; 10] = match edge_refs.as_slice().try_into() {
                    Ok(a) => a,
                    Err(_) => return Ok(None),
                };
                self.provider.wcoj_clique5_u64_recorded_planned(
                    arr,
                    plan_params.leader_edge_idx,
                    &plan_params.edge_order,
                    &plan_params.iteration_order,
                    launch_stream,
                )
            }
            (6, false) => {
                let arr: &[&CudaBuffer; 15] = match edge_refs.as_slice().try_into() {
                    Ok(a) => a,
                    Err(_) => return Ok(None),
                };
                self.provider.wcoj_clique6_u32_recorded_planned(
                    arr,
                    plan_params.leader_edge_idx,
                    &plan_params.edge_order,
                    &plan_params.iteration_order,
                    launch_stream,
                )
            }
            (6, true) => {
                let arr: &[&CudaBuffer; 15] = match edge_refs.as_slice().try_into() {
                    Ok(a) => a,
                    Err(_) => return Ok(None),
                };
                self.provider.wcoj_clique6_u64_recorded_planned(
                    arr,
                    plan_params.leader_edge_idx,
                    &plan_params.edge_order,
                    &plan_params.iteration_order,
                    launch_stream,
                )
            }
            (7, false) => {
                let arr: &[&CudaBuffer; 21] = match edge_refs.as_slice().try_into() {
                    Ok(a) => a,
                    Err(_) => return Ok(None),
                };
                self.provider.wcoj_clique7_u32_recorded_planned(
                    arr,
                    plan_params.leader_edge_idx,
                    &plan_params.edge_order,
                    &plan_params.iteration_order,
                    launch_stream,
                )
            }
            (7, true) => {
                let arr: &[&CudaBuffer; 21] = match edge_refs.as_slice().try_into() {
                    Ok(a) => a,
                    Err(_) => return Ok(None),
                };
                self.provider.wcoj_clique7_u64_recorded_planned(
                    arr,
                    plan_params.leader_edge_idx,
                    &plan_params.edge_order,
                    &plan_params.iteration_order,
                    launch_stream,
                )
            }
            (8, false) => {
                let arr: &[&CudaBuffer; 28] = match edge_refs.as_slice().try_into() {
                    Ok(a) => a,
                    Err(_) => return Ok(None),
                };
                self.provider.wcoj_clique8_u32_recorded_planned(
                    arr,
                    plan_params.leader_edge_idx,
                    &plan_params.edge_order,
                    &plan_params.iteration_order,
                    launch_stream,
                )
            }
            (8, true) => {
                let arr: &[&CudaBuffer; 28] = match edge_refs.as_slice().try_into() {
                    Ok(a) => a,
                    Err(_) => return Ok(None),
                };
                self.provider.wcoj_clique8_u64_recorded_planned(
                    arr,
                    plan_params.leader_edge_idx,
                    &plan_params.edge_order,
                    &plan_params.iteration_order,
                    launch_stream,
                )
            }
            _ => return Ok(None),
        };
        // 9. On success: counter++, return Some. On error:
        // silent fallback (no counter advance).
        match result {
            Ok(buf) => {
                let buf = if output_perm.iter().copied().eq(0..output_perm.len()) {
                    buf
                } else {
                    self.provider.wcoj_project_output_columns_recorded(
                        &buf,
                        &output_perm,
                        head_schema,
                        launch_stream,
                    )?
                };
                match k {
                    5 => self.wcoj_clique5_dispatch_count += 1,
                    6 => self.wcoj_clique6_dispatch_count += 1,
                    7 => self.wcoj_clique7_dispatch_count += 1,
                    8 => self.wcoj_clique8_dispatch_count += 1,
                    _ => {}
                }
                Ok(Some(buf))
            }
            Err(err) => wcoj_decline_on_error(&mut self.wcoj_error_decline_count, "k-clique", err),
        }
    }

    /// Orient edges according to a `KCliqueVariableOrder` (edge
    /// permutation + column swaps), then layout the plan-required
    /// physical slots through the generic layout-sort helper and the
    /// remaining 2-column slots through the narrower WCOJ layout entry
    /// (which preserves correctness and can take the sorted-unique fast
    /// path). Shared by the unfused K-clique dispatch and the fused
    /// count-by-root dispatch; callers wrap errors through
    /// [`wcoj_decline_on_error`].
    fn orient_and_layout_kclique_edges(
        &self,
        raw_bufs: &[&CudaBuffer],
        plan_params: &KCliqueDispatchParams,
        is_u64: bool,
        launch_stream: StreamId,
    ) -> Result<Vec<CudaBuffer>> {
        let mut laid_out: Vec<CudaBuffer> = Vec::with_capacity(plan_params.edge_permutation.len());
        for (slot, &input_idx) in plan_params.edge_permutation.iter().enumerate() {
            let src = raw_bufs[input_idx];
            let swapped = if plan_params.swap_slots.contains(&slot) {
                Some(
                    self.provider
                        .wcoj_project_2col_swap_recorded(src, launch_stream)?,
                )
            } else {
                None
            };
            let oriented = swapped.as_ref().unwrap_or(src);
            let res = if plan_params.required_sort_slots.contains(&slot) {
                if is_u64 {
                    self.provider
                        .wcoj_layout_sort_u64_recorded(oriented, launch_stream)
                } else {
                    self.provider
                        .wcoj_layout_sort_u32_recorded(oriented, launch_stream)
                }
            } else if is_u64 {
                self.provider
                    .wcoj_layout_u64_recorded(oriented, launch_stream)
            } else {
                self.provider
                    .wcoj_layout_u32_recorded(oriented, launch_stream)
            };
            laid_out.push(res?);
        }
        Ok(laid_out)
    }

    /// Aggregate-fused WCOJ, K-clique count (K = 5, 6; 4-byte keys):
    /// dispatch the inner `MultiWayJoin(K-clique)` of a count-by-root
    /// aggregate through the fused group-by-root kernel, which never
    /// materializes the clique rows.
    ///
    /// CAREFUL — the root under `KCliqueVariableOrder` is plan-dependent
    /// (`variable_order[0]` + leader-edge orientation/swaps determine the
    /// physical root column). The fusion is sound only when the GroupBy
    /// key column references the head variable whose planned position is
    /// 0 (`variable_positions[r] == 0`); everything else declines
    /// silently to the embedded fallback + groupby path. K = 7/8 (no
    /// fused kernels), u64/mixed widths, planned-hash routes, and
    /// missing buffers/runtime also decline. Kill switch
    /// (`XLOG_DISABLE_WCOJ_GROUPBY_FUSION`) is checked by the caller.
    /// Pipeline errors route through [`wcoj_decline_on_error`] (counted;
    /// `XLOG_WCOJ_STRICT=1` propagates).
    fn try_dispatch_wcoj_groupby_root_count_clique(
        &mut self,
        multiway: &RirNode,
        group_cols: &[ProjectExpr],
    ) -> Result<Option<CudaBuffer>> {
        let RirNode::MultiWayJoin {
            inputs,
            plan,
            var_order,
            ..
        } = multiway
        else {
            return Ok(None);
        };
        if matches!(plan, Some(MultiwayPlan::PlannedHashRoute { .. })) {
            return Ok(None);
        }
        let kclique = match var_order.as_ref().and_then(|order| order.kclique.as_ref()) {
            Some(plan) => plan,
            None => return Ok(None),
        };
        let k = usize::from(kclique.k);
        if !matches!(k, 5 | 6) {
            return Ok(None);
        }
        let expected_edges = k * (k - 1) / 2;
        if inputs.len() != expected_edges {
            return Ok(None);
        }
        // Group key must be the planned position-0 root variable.
        let Some(ProjectExpr::Column(root_var)) = group_cols.first() else {
            return Ok(None);
        };
        let Some(positions) = live_kclique_variable_positions(kclique, k) else {
            return Ok(None);
        };
        if *root_var >= k || positions[*root_var] != 0 {
            return Ok(None);
        }
        // Resolve scans → buffers; only uniform 4-byte keys are fused.
        let mut rel_ids: Vec<RelId> = Vec::with_capacity(expected_edges);
        for input in inputs {
            let RirNode::Scan { rel } = input else {
                return Ok(None);
            };
            rel_ids.push(*rel);
        }
        let mut raw_bufs: Vec<&CudaBuffer> = Vec::with_capacity(expected_edges);
        for rid in &rel_ids {
            let name = match self.rel_names.get(rid) {
                Some(n) => n.clone(),
                None => return Ok(None),
            };
            match self.store.get(&name) {
                Some(b) => raw_bufs.push(b),
                None => return Ok(None),
            }
        }
        for buf in &raw_bufs {
            if classify_two_col_wcoj_width(buf) != Some(WcojKeyWidth::FourByte) {
                return Ok(None);
            }
        }
        if self.provider.memory().runtime().is_none() {
            return Ok(None);
        }
        let Some(launch_stream) = self.wcoj_dispatch_stream_or_init() else {
            return Ok(None);
        };
        let Some(plan_params) = kclique_dispatch_params(kclique, k) else {
            return Ok(None);
        };
        let laid_out = match self.orient_and_layout_kclique_edges(
            &raw_bufs,
            &plan_params,
            false,
            launch_stream,
        ) {
            Ok(bufs) => bufs,
            Err(err) => {
                return wcoj_decline_on_error(
                    &mut self.wcoj_error_decline_count,
                    "groupby-fusion-clique-layout",
                    err,
                )
            }
        };
        let edge_refs: Vec<&CudaBuffer> = laid_out.iter().collect();
        let result = match k {
            5 => {
                let arr: &[&CudaBuffer; 10] = match edge_refs.as_slice().try_into() {
                    Ok(a) => a,
                    Err(_) => return Ok(None),
                };
                self.provider
                    .wcoj_clique5_groupby_root_count_u32_recorded_planned(
                        arr,
                        plan_params.leader_edge_idx,
                        &plan_params.edge_order,
                        &plan_params.iteration_order,
                        launch_stream,
                    )
            }
            _ => {
                let arr: &[&CudaBuffer; 15] = match edge_refs.as_slice().try_into() {
                    Ok(a) => a,
                    Err(_) => return Ok(None),
                };
                self.provider
                    .wcoj_clique6_groupby_root_count_u32_recorded_planned(
                        arr,
                        plan_params.leader_edge_idx,
                        &plan_params.edge_order,
                        &plan_params.iteration_order,
                        launch_stream,
                    )
            }
        };
        match result {
            Ok(buf) => {
                self.wcoj_groupby_fusion_dispatch_count += 1;
                Ok(Some(buf))
            }
            Err(err) => wcoj_decline_on_error(
                &mut self.wcoj_error_decline_count,
                "groupby-fusion-clique",
                err,
            ),
        }
    }
}

#[derive(Debug)]
struct KCliqueDispatchParams {
    edge_permutation: Vec<usize>,
    edge_order: Vec<u8>,
    iteration_order: Vec<u8>,
    leader_edge_idx: u32,
    swap_slots: HashSet<usize>,
    required_sort_slots: HashSet<usize>,
}

fn kclique_dispatch_params(plan: &KCliqueVariableOrder, k: usize) -> Option<KCliqueDispatchParams> {
    let expected_edges = k * (k - 1) / 2;
    let edge_permutation = live_kclique_edge_permutation(plan, expected_edges)?;
    let positions = live_kclique_variable_positions(plan, k)?;
    let mut edge_order = vec![u8::MAX; expected_edges];

    for (slot, &edge_idx) in edge_permutation.iter().enumerate() {
        let (left, right) = clique_edge_pair(edge_idx, k)?;
        let left_pos = positions[left];
        let right_pos = positions[right];
        let logical_edge =
            clique_edge_idx_runtime(left_pos.min(right_pos), left_pos.max(right_pos), k)?;
        edge_order[logical_edge] = u8::try_from(slot).ok()?;
    }
    if edge_order.contains(&u8::MAX) {
        return None;
    }
    let leader_edge_idx = u32::from(edge_order[clique_edge_idx_runtime(0, 1, k)?]);
    let iteration_order: Vec<u8> = (0..k)
        .map(|idx| u8::try_from(idx).ok())
        .collect::<Option<_>>()?;

    let swap_slots: HashSet<usize> = plan
        .column_swaps
        .iter()
        .filter(|swap| swap.swap_cols)
        .map(|swap| usize::from(swap.edge_slot))
        .collect();
    if swap_slots.iter().any(|slot| *slot >= expected_edges) {
        return None;
    }
    let required_sort_slots: HashSet<usize> = plan
        .sorted_layout_requirements
        .edge_slots
        .iter()
        .copied()
        .map(usize::from)
        .collect();
    if required_sort_slots
        .iter()
        .any(|slot| *slot >= expected_edges)
    {
        return None;
    }

    Some(KCliqueDispatchParams {
        edge_permutation,
        edge_order,
        iteration_order,
        leader_edge_idx,
        swap_slots,
        required_sort_slots,
    })
}

fn live_kclique_edge_permutation(
    plan: &KCliqueVariableOrder,
    expected_edges: usize,
) -> Option<Vec<usize>> {
    let values: Vec<usize> = plan
        .edge_permutation
        .iter()
        .copied()
        .take_while(|value| *value != u8::MAX)
        .map(usize::from)
        .collect();
    if values.len() != expected_edges {
        return None;
    }
    let mut seen = vec![false; expected_edges];
    for &value in &values {
        if value >= expected_edges || seen[value] {
            return None;
        }
        seen[value] = true;
    }
    Some(values)
}

fn live_kclique_variable_positions(plan: &KCliqueVariableOrder, k: usize) -> Option<Vec<usize>> {
    let mut positions = Vec::with_capacity(k);
    let mut seen = vec![false; k];
    for original_var in 0..k {
        let pos = usize::from(*plan.variable_positions.get(original_var)?);
        if pos >= k || seen[pos] {
            return None;
        }
        seen[pos] = true;
        positions.push(pos);
    }
    Some(positions)
}

fn clique_edge_idx_runtime(i: usize, j: usize, k: usize) -> Option<usize> {
    if !(i < j && j < k) {
        return None;
    }
    Some(i * (k - 1) - i.saturating_sub(1) * i / 2 + (j - i - 1))
}

fn clique_edge_pair(edge_idx: usize, k: usize) -> Option<(usize, usize)> {
    let mut idx = 0usize;
    for i in 0..k {
        for j in (i + 1)..k {
            if idx == edge_idx {
                return Some((i, j));
            }
            idx += 1;
        }
    }
    None
}

fn build_kclique_head_schema(raw_bufs: &[&CudaBuffer], k: usize) -> Option<Schema> {
    let mut columns = Vec::with_capacity(k);
    for variable in 0..k {
        let (edge_idx, col_idx) = if variable == 0 {
            (clique_edge_idx_runtime(0, 1, k)?, 0)
        } else {
            (clique_edge_idx_runtime(0, variable, k)?, 1)
        };
        let ty = raw_bufs.get(edge_idx)?.schema().column_type(col_idx)?;
        columns.push((format!("col{}", variable), ty));
    }
    Some(Schema::new(columns))
}

fn kclique_output_perm(plan: &KCliqueVariableOrder, k: usize) -> Option<Vec<usize>> {
    let positions = live_kclique_variable_positions(plan, k)?;
    Some(positions)
}

#[cfg(test)]
mod tests {
    use std::sync::{Mutex, OnceLock};

    use super::{
        chain_dispatch_enabled, match_chain_join, match_multiway_triangle,
        record_chain_fallback_equivalents, wcoj_adaptive_enabled, wcoj_gate_enabled,
        wcoj_triangle_disabled, ENV_DISABLE_WCOJ_TRIANGLE, ENV_USE_WCOJ_TRIANGLE_U32,
        ENV_WCOJ_CHAIN_ENABLE,
    };
    use xlog_core::RelId;
    use xlog_ir::rir::ProjectExpr;
    use xlog_ir::RirNode;

    fn canonical_multiway() -> RirNode {
        RirNode::MultiWayJoin {
            inputs: vec![
                RirNode::Scan { rel: RelId(1) },
                RirNode::Scan { rel: RelId(2) },
                RirNode::Scan { rel: RelId(3) },
            ],
            slot_vars: vec![
                vec![Some(0u32), Some(1)],
                vec![Some(1u32), Some(2)],
                vec![Some(0u32), Some(2)],
            ],
            output_columns: vec![
                ProjectExpr::Column(0),
                ProjectExpr::Column(1),
                ProjectExpr::Column(3),
            ],
            fallback: Box::new(RirNode::Unit),
            plan: None,
            var_order: None,
        }
    }

    fn canonical_chain_join() -> RirNode {
        RirNode::ChainJoin {
            left: Box::new(RirNode::Scan { rel: RelId(1) }),
            right: Box::new(RirNode::Scan { rel: RelId(2) }),
            left_key: 1,
            right_key: 0,
            output_columns: vec![ProjectExpr::Column(0), ProjectExpr::Column(3)],
            fallback: Box::new(RirNode::Unit),
        }
    }

    #[test]
    fn match_chain_returns_two_rels_and_keys() {
        let node = canonical_chain_join();
        let m = match_chain_join(&node).expect("must match canonical chain");
        assert_eq!(m.rel_left, RelId(1));
        assert_eq!(m.rel_right, RelId(2));
        assert_eq!(m.left_key, 1);
        assert_eq!(m.right_key, 0);
        assert_eq!(
            m.output_columns,
            vec![ProjectExpr::Column(0), ProjectExpr::Column(3)]
        );
    }

    #[test]
    fn match_chain_rejects_non_scan_inputs() {
        let mut node = canonical_chain_join();
        if let RirNode::ChainJoin { left, .. } = &mut node {
            **left = RirNode::Unit;
        }
        assert!(match_chain_join(&node).is_none());
    }

    #[test]
    fn match_chain_rejects_multiway_triangle() {
        let node = canonical_multiway();
        assert!(match_chain_join(&node).is_none());
    }

    fn chain_with_scan_filter_fallback() -> RirNode {
        let mut node = canonical_chain_join();
        let RirNode::ChainJoin { fallback, .. } = &mut node else {
            unreachable!("canonical chain shape")
        };
        **fallback = RirNode::Union {
            inputs: vec![
                RirNode::Filter {
                    input: Box::new(RirNode::Scan { rel: RelId(1) }),
                    predicate: xlog_ir::Expr::And(Vec::new()),
                },
                RirNode::Project {
                    input: Box::new(RirNode::Filter {
                        input: Box::new(RirNode::Scan { rel: RelId(2) }),
                        predicate: xlog_ir::Expr::And(Vec::new()),
                    }),
                    columns: vec![ProjectExpr::Column(0)],
                },
            ],
        };
        node
    }

    #[test]
    fn matched_chain_success_records_embedded_fallback_equivalents() {
        let node = chain_with_scan_filter_fallback();
        let mut scans = 7;
        let mut filters = 11;

        record_chain_fallback_equivalents(&node, true, &mut scans, &mut filters);

        assert_eq!(scans, 9);
        assert_eq!(filters, 13);
    }

    #[test]
    fn matched_chain_decline_records_no_embedded_fallback_equivalents() {
        let node = chain_with_scan_filter_fallback();
        let mut scans = 7;
        let mut filters = 11;

        record_chain_fallback_equivalents(&node, false, &mut scans, &mut filters);

        assert_eq!(scans, 7);
        assert_eq!(filters, 11);
    }

    #[test]
    fn chain_dispatch_env_defaults_on_and_can_disable() {
        static ENV_LOCK: OnceLock<Mutex<()>> = OnceLock::new();
        let _guard = ENV_LOCK.get_or_init(|| Mutex::new(())).lock().unwrap();
        let old = std::env::var(ENV_WCOJ_CHAIN_ENABLE).ok();
        // SAFETY: This test holds a local mutex while mutating the
        // process-global chain-dispatch env var, and restores it before unlock.
        unsafe {
            std::env::remove_var(ENV_WCOJ_CHAIN_ENABLE);
        }
        assert!(chain_dispatch_enabled().unwrap());
        unsafe {
            std::env::set_var(ENV_WCOJ_CHAIN_ENABLE, "0");
        }
        assert!(!chain_dispatch_enabled().unwrap());
        unsafe {
            std::env::set_var(ENV_WCOJ_CHAIN_ENABLE, "false");
        }
        assert!(!chain_dispatch_enabled().unwrap());
        unsafe {
            std::env::set_var(ENV_WCOJ_CHAIN_ENABLE, "1");
        }
        assert!(chain_dispatch_enabled().unwrap());
        unsafe {
            match old {
                Some(v) => std::env::set_var(ENV_WCOJ_CHAIN_ENABLE, v),
                None => std::env::remove_var(ENV_WCOJ_CHAIN_ENABLE),
            }
        }
    }

    #[test]
    fn match_canonical_returns_three_rels() {
        let node = canonical_multiway();
        let m = match_multiway_triangle(&node).expect("must match canonical triangle");
        assert_eq!(m.rel_xy, RelId(1));
        assert_eq!(m.rel_yz, RelId(2));
        assert_eq!(m.rel_xz, RelId(3));
    }

    #[test]
    fn match_rejects_non_multiway_body() {
        let node = RirNode::Scan { rel: RelId(1) };
        assert!(match_multiway_triangle(&node).is_none());
    }

    #[test]
    fn match_rejects_rotated_output_columns() {
        let mut node = canonical_multiway();
        if let RirNode::MultiWayJoin { output_columns, .. } = &mut node {
            *output_columns = vec![
                ProjectExpr::Column(1),
                ProjectExpr::Column(0),
                ProjectExpr::Column(3),
            ];
        }
        assert!(match_multiway_triangle(&node).is_none());
    }

    /// Triangle with Z-shared output_columns layout
    /// `[Column(0), Column(2), Column(3)]` must match. The
    /// matcher's output-column relaxation accepts both
    /// `[0, 1, 3]` (Y/X-shared) and `[0, 2, 3]` (Z-shared).
    #[test]
    fn match_accepts_z_shared_triangle_output_columns() {
        let mut node = canonical_multiway();
        if let RirNode::MultiWayJoin { output_columns, .. } = &mut node {
            *output_columns = vec![
                ProjectExpr::Column(0),
                ProjectExpr::Column(2),
                ProjectExpr::Column(3),
            ];
        }
        let m = match_multiway_triangle(&node)
            .expect("matcher must accept the Z-shared output-column layout");
        assert_eq!(m.rel_xy, RelId(1));
        assert_eq!(m.rel_yz, RelId(2));
        assert_eq!(m.rel_xz, RelId(3));
    }

    /// Triangle output_columns `[Column(0), Column(3), Column(3)]`
    /// MUST be rejected — second col must be 1 or 2, not 3.
    #[test]
    fn match_rejects_invalid_triangle_output_columns() {
        let mut node = canonical_multiway();
        if let RirNode::MultiWayJoin { output_columns, .. } = &mut node {
            *output_columns = vec![
                ProjectExpr::Column(0),
                ProjectExpr::Column(3),
                ProjectExpr::Column(3),
            ];
        }
        assert!(match_multiway_triangle(&node).is_none());
    }

    #[test]
    fn match_rejects_arity_mismatched_output_columns() {
        let mut node = canonical_multiway();
        if let RirNode::MultiWayJoin { output_columns, .. } = &mut node {
            *output_columns = vec![ProjectExpr::Column(0), ProjectExpr::Column(1)];
        }
        assert!(match_multiway_triangle(&node).is_none());
    }

    #[test]
    fn match_rejects_malformed_slot_vars() {
        // [[A,B],[B,C],[A,B]] — last slot is wrong (should be [A,C]).
        let mut node = canonical_multiway();
        if let RirNode::MultiWayJoin { slot_vars, .. } = &mut node {
            *slot_vars = vec![
                vec![Some(0u32), Some(1)],
                vec![Some(1u32), Some(2)],
                vec![Some(0u32), Some(1)],
            ];
        }
        assert!(match_multiway_triangle(&node).is_none());
    }

    #[test]
    fn match_rejects_repeated_var_in_slot() {
        let mut node = canonical_multiway();
        if let RirNode::MultiWayJoin { slot_vars, .. } = &mut node {
            // [[A, A], …] — repeated var in slot 0.
            *slot_vars = vec![
                vec![Some(0u32), Some(0)],
                vec![Some(1u32), Some(2)],
                vec![Some(0u32), Some(2)],
            ];
        }
        assert!(match_multiway_triangle(&node).is_none());
    }

    #[test]
    fn match_rejects_non_scan_input() {
        let mut node = canonical_multiway();
        if let RirNode::MultiWayJoin { inputs, .. } = &mut node {
            inputs[0] = RirNode::Unit;
        }
        assert!(match_multiway_triangle(&node).is_none());
    }

    #[test]
    fn match_rejects_input_arity_mismatch() {
        let mut node = canonical_multiway();
        if let RirNode::MultiWayJoin { inputs, .. } = &mut node {
            inputs.pop();
        }
        assert!(match_multiway_triangle(&node).is_none());
    }

    fn env_lock() -> &'static Mutex<()> {
        static LOCK: OnceLock<Mutex<()>> = OnceLock::new();
        LOCK.get_or_init(|| Mutex::new(()))
    }

    struct EnvSnapshot {
        force: Option<String>,
        disable: Option<String>,
    }

    impl EnvSnapshot {
        fn capture_and_clear() -> Self {
            let snapshot = Self {
                force: std::env::var(ENV_USE_WCOJ_TRIANGLE_U32).ok(),
                disable: std::env::var(ENV_DISABLE_WCOJ_TRIANGLE).ok(),
            };

            // SAFETY: The caller holds `env_lock`, serializing mutation of
            // this process-global WCOJ env var.
            unsafe {
                std::env::remove_var(ENV_USE_WCOJ_TRIANGLE_U32);
                std::env::remove_var(ENV_DISABLE_WCOJ_TRIANGLE);
            }

            snapshot
        }
    }

    impl Drop for EnvSnapshot {
        fn drop(&mut self) {
            // SAFETY: The snapshot is dropped before `env_lock` is released,
            // so restoration is serialized even if the test body panics.
            unsafe {
                match self.force.take() {
                    Some(v) => std::env::set_var(ENV_USE_WCOJ_TRIANGLE_U32, v),
                    None => std::env::remove_var(ENV_USE_WCOJ_TRIANGLE_U32),
                }
                match self.disable.take() {
                    Some(v) => std::env::set_var(ENV_DISABLE_WCOJ_TRIANGLE, v),
                    None => std::env::remove_var(ENV_DISABLE_WCOJ_TRIANGLE),
                }
            }
        }
    }

    fn with_wcoj_env<R>(f: impl FnOnce() -> R) -> R {
        let _guard = env_lock().lock().expect("WCOJ env lock poisoned");
        let _snapshot = EnvSnapshot::capture_and_clear();
        f()
    }

    fn set_env(name: &str, value: &str) {
        // SAFETY: Callers are inside `with_wcoj_env`, which serializes and
        // restores these process-global WCOJ env vars.
        unsafe {
            std::env::set_var(name, value);
        }
    }

    #[test]
    fn stats_gate_defaults_on_when_env_unset() {
        with_wcoj_env(|| {
            assert!(wcoj_adaptive_enabled(None));
            assert!(wcoj_adaptive_enabled(Some(true)));
            assert!(!wcoj_adaptive_enabled(Some(false)));
        });
    }

    #[test]
    fn config_controls_stats_gate() {
        with_wcoj_env(|| {
            assert!(wcoj_adaptive_enabled(Some(true)));
            assert!(!wcoj_adaptive_enabled(Some(false)));
        });
    }

    #[test]
    fn force_resolver_config_still_overrides_env() {
        with_wcoj_env(|| {
            set_env(ENV_USE_WCOJ_TRIANGLE_U32, "1");
            assert!(wcoj_gate_enabled(None).unwrap());
            assert!(!wcoj_gate_enabled(Some(false)).unwrap());

            set_env(ENV_USE_WCOJ_TRIANGLE_U32, "0");
            assert!(!wcoj_gate_enabled(None).unwrap());
            assert!(wcoj_gate_enabled(Some(true)).unwrap());
        });
    }

    #[test]
    fn triangle_kill_switch_honors_environment_and_explicit_config() {
        with_wcoj_env(|| {
            assert!(!wcoj_triangle_disabled(None).unwrap());
            set_env(ENV_DISABLE_WCOJ_TRIANGLE, "yes");
            assert!(wcoj_triangle_disabled(None).unwrap());
            assert!(!wcoj_triangle_disabled(Some(false)).unwrap());
            set_env(ENV_DISABLE_WCOJ_TRIANGLE, "off");
            assert!(wcoj_triangle_disabled(Some(true)).unwrap());
        });
    }

    #[test]
    fn malformed_wcoj_boolean_is_a_typed_configuration_error() {
        with_wcoj_env(|| {
            set_env(ENV_USE_WCOJ_TRIANGLE_U32, "sometimes");
            assert!(matches!(
                wcoj_gate_enabled(None),
                Err(xlog_core::XlogError::Configuration { ref name, .. })
                    if name == ENV_USE_WCOJ_TRIANGLE_U32
            ));
            assert!(!wcoj_gate_enabled(Some(false)).unwrap());
        });
    }

    // -------------------------------------------------------------
    // WCOJ error-decline observability (counter + XLOG_WCOJ_STRICT).
    // -------------------------------------------------------------

    #[test]
    fn error_decline_counts_and_falls_back_by_default() {
        with_wcoj_env(|| {
            let mut counter = 0u64;
            let err = xlog_core::XlogError::Kernel("synthetic layout failure".to_string());
            let out = super::wcoj_decline_on_error(&mut counter, "triangle", err)
                .expect("default mode must decline to the binary-join fallback, not error");
            assert!(out.is_none(), "decline must hand control to the fallback");
            assert_eq!(counter, 1, "every error decline must be counted");
        });
    }

    #[test]
    fn error_decline_propagates_under_strict_env() {
        with_wcoj_env(|| {
            set_env(super::ENV_WCOJ_STRICT, "1");
            let mut counter = 0u64;
            let err = xlog_core::XlogError::Kernel("synthetic layout failure".to_string());
            let out = super::wcoj_decline_on_error(&mut counter, "triangle", err);
            // SAFETY: serialized + restored under `with_wcoj_env`'s lock.
            unsafe {
                std::env::remove_var(super::ENV_WCOJ_STRICT);
            }
            match out {
                Err(err) => assert!(
                    err.to_string().contains("synthetic layout failure"),
                    "strict mode must surface the original error: {err}"
                ),
                Ok(_) => panic!("XLOG_WCOJ_STRICT=1 must propagate the pipeline error"),
            }
            assert_eq!(counter, 1, "strict mode still counts the decline");
        });
    }

    // -------------------------------------------------------------
    // 4-cycle env-resolver + matcher tests.
    // -------------------------------------------------------------

    use super::{
        match_multiway_4cycle, wcoj_4cycle_adaptive_enabled, wcoj_4cycle_disabled,
        wcoj_4cycle_gate_enabled, ENV_DISABLE_WCOJ_4CYCLE, ENV_USE_WCOJ_4CYCLE,
        ENV_USE_WCOJ_4CYCLE_ADAPTIVE,
    };

    struct EnvSnapshot4Cycle {
        force: Option<String>,
        adaptive: Option<String>,
        disable: Option<String>,
    }

    impl EnvSnapshot4Cycle {
        fn capture_and_clear() -> Self {
            let snap = Self {
                force: std::env::var(ENV_USE_WCOJ_4CYCLE).ok(),
                adaptive: std::env::var(ENV_USE_WCOJ_4CYCLE_ADAPTIVE).ok(),
                disable: std::env::var(ENV_DISABLE_WCOJ_4CYCLE).ok(),
            };
            // SAFETY: caller holds env_lock.
            unsafe {
                std::env::remove_var(ENV_USE_WCOJ_4CYCLE);
                std::env::remove_var(ENV_USE_WCOJ_4CYCLE_ADAPTIVE);
                std::env::remove_var(ENV_DISABLE_WCOJ_4CYCLE);
            }
            snap
        }
    }

    impl Drop for EnvSnapshot4Cycle {
        fn drop(&mut self) {
            // SAFETY: caller holds env_lock.
            unsafe {
                match self.force.take() {
                    Some(v) => std::env::set_var(ENV_USE_WCOJ_4CYCLE, v),
                    None => std::env::remove_var(ENV_USE_WCOJ_4CYCLE),
                }
                match self.adaptive.take() {
                    Some(v) => std::env::set_var(ENV_USE_WCOJ_4CYCLE_ADAPTIVE, v),
                    None => std::env::remove_var(ENV_USE_WCOJ_4CYCLE_ADAPTIVE),
                }
                match self.disable.take() {
                    Some(v) => std::env::set_var(ENV_DISABLE_WCOJ_4CYCLE, v),
                    None => std::env::remove_var(ENV_DISABLE_WCOJ_4CYCLE),
                }
            }
        }
    }

    fn with_4cycle_env<R>(f: impl FnOnce() -> R) -> R {
        let _guard = env_lock().lock().expect("4-cycle env lock poisoned");
        let _snap = EnvSnapshot4Cycle::capture_and_clear();
        f()
    }

    #[test]
    fn force_4cycle_resolver_defaults_off_when_env_unset() {
        with_4cycle_env(|| {
            assert!(!wcoj_4cycle_gate_enabled(None).unwrap());
            assert!(wcoj_4cycle_gate_enabled(Some(true)).unwrap());
            assert!(!wcoj_4cycle_gate_enabled(Some(false)).unwrap());
        });
    }

    #[test]
    fn force_4cycle_resolver_env_can_enable() {
        with_4cycle_env(|| {
            set_env(ENV_USE_WCOJ_4CYCLE, "1");
            assert!(wcoj_4cycle_gate_enabled(None).unwrap());
            set_env(ENV_USE_WCOJ_4CYCLE, "true");
            assert!(wcoj_4cycle_gate_enabled(None).unwrap());
            set_env(ENV_USE_WCOJ_4CYCLE, "0");
            assert!(!wcoj_4cycle_gate_enabled(None).unwrap());
        });
    }

    /// **Locks the 4-cycle adaptive contract**: adaptive opt-in
    /// defaults OFF, unlike triangle's default-on. If a future
    /// default flips, that change must update this test
    /// explicitly with bench evidence.
    #[test]
    fn adaptive_4cycle_resolver_defaults_off_when_env_unset() {
        with_4cycle_env(|| {
            assert!(
                !wcoj_4cycle_adaptive_enabled(None).unwrap(),
                "4-cycle adaptive must be OPT-IN by default (unlike triangle's default-on)"
            );
            assert!(wcoj_4cycle_adaptive_enabled(Some(true)).unwrap());
            assert!(!wcoj_4cycle_adaptive_enabled(Some(false)).unwrap());
        });
    }

    #[test]
    fn adaptive_4cycle_resolver_env_can_enable() {
        with_4cycle_env(|| {
            set_env(ENV_USE_WCOJ_4CYCLE_ADAPTIVE, "1");
            assert!(wcoj_4cycle_adaptive_enabled(None).unwrap());
            set_env(ENV_USE_WCOJ_4CYCLE_ADAPTIVE, "0");
            assert!(!wcoj_4cycle_adaptive_enabled(None).unwrap());
            set_env(ENV_USE_WCOJ_4CYCLE_ADAPTIVE, "true");
            assert!(wcoj_4cycle_adaptive_enabled(None).unwrap());
        });
    }

    #[test]
    fn kill_4cycle_resolver_honors_env_and_config() {
        with_4cycle_env(|| {
            assert!(!wcoj_4cycle_disabled(None).unwrap());
            set_env(ENV_DISABLE_WCOJ_4CYCLE, "1");
            assert!(wcoj_4cycle_disabled(None).unwrap());
            assert!(!wcoj_4cycle_disabled(Some(false)).unwrap());
            set_env(ENV_DISABLE_WCOJ_4CYCLE, "0");
            assert!(wcoj_4cycle_disabled(Some(true)).unwrap());
        });
    }

    fn canonical_4cycle_multiway() -> RirNode {
        RirNode::MultiWayJoin {
            inputs: vec![
                RirNode::Scan { rel: RelId(1) },
                RirNode::Scan { rel: RelId(2) },
                RirNode::Scan { rel: RelId(3) },
                RirNode::Scan { rel: RelId(4) },
            ],
            slot_vars: vec![
                vec![Some(0u32), Some(1)],
                vec![Some(1u32), Some(2)],
                vec![Some(2u32), Some(3)],
                vec![Some(3u32), Some(0)],
            ],
            output_columns: vec![
                ProjectExpr::Column(0),
                ProjectExpr::Column(1),
                ProjectExpr::Column(3),
                ProjectExpr::Column(5),
            ],
            fallback: Box::new(RirNode::Unit),
            plan: None,
            var_order: None,
        }
    }

    #[test]
    fn match_4cycle_canonical_returns_four_rels() {
        let node = canonical_4cycle_multiway();
        let m = match_multiway_4cycle(&node).expect("must match canonical 4-cycle");
        assert_eq!(m.rel_e1, RelId(1));
        assert_eq!(m.rel_e2, RelId(2));
        assert_eq!(m.rel_e3, RelId(3));
        assert_eq!(m.rel_e4, RelId(4));
    }

    #[test]
    fn match_4cycle_rejects_non_multiway() {
        assert!(match_multiway_4cycle(&RirNode::Scan { rel: RelId(1) }).is_none());
    }

    #[test]
    fn match_4cycle_rejects_triangle_shape() {
        // Triangle is 3 inputs — 4-cycle matcher must reject.
        let triangle = RirNode::MultiWayJoin {
            inputs: vec![
                RirNode::Scan { rel: RelId(1) },
                RirNode::Scan { rel: RelId(2) },
                RirNode::Scan { rel: RelId(3) },
            ],
            slot_vars: vec![
                vec![Some(0u32), Some(1)],
                vec![Some(1u32), Some(2)],
                vec![Some(0u32), Some(2)],
            ],
            output_columns: vec![
                ProjectExpr::Column(0),
                ProjectExpr::Column(1),
                ProjectExpr::Column(3),
            ],
            fallback: Box::new(RirNode::Unit),
            plan: None,
            var_order: None,
        };
        assert!(match_multiway_4cycle(&triangle).is_none());
    }

    #[test]
    fn match_4cycle_rejects_rotated_output_columns() {
        let mut node = canonical_4cycle_multiway();
        if let RirNode::MultiWayJoin { output_columns, .. } = &mut node {
            output_columns.swap(0, 1);
        }
        assert!(match_multiway_4cycle(&node).is_none());
    }

    /// 4-cycle Alt-grouping output_columns
    /// `[Column(5), Column(0), Column(1), Column(3)]` must
    /// match. The matcher relaxation accepts both
    /// Default `[0, 1, 3, 5]` and Alt `[5, 0, 1, 3]`.
    #[test]
    fn match_4cycle_accepts_alt_grouping_output_columns() {
        let mut node = canonical_4cycle_multiway();
        if let RirNode::MultiWayJoin { output_columns, .. } = &mut node {
            *output_columns = vec![
                ProjectExpr::Column(5),
                ProjectExpr::Column(0),
                ProjectExpr::Column(1),
                ProjectExpr::Column(3),
            ];
        }
        let m = match_multiway_4cycle(&node)
            .expect("matcher must accept the Alt-grouping output-column layout");
        // RelIds preserved positionally from the body's
        // MultiWayJoin.inputs (which are in canonical
        // semantic order [WX, XY, YZ, ZW]).
        assert_eq!(m.rel_e1, RelId(1));
        assert_eq!(m.rel_e2, RelId(2));
        assert_eq!(m.rel_e3, RelId(3));
        assert_eq!(m.rel_e4, RelId(4));
    }

    /// 4-cycle output_columns `[1, 0, 3, 5]` (only swap
    /// of cols 0 and 1 vs Default) must STILL be rejected —
    /// it's neither Default nor Alt.
    #[test]
    fn match_4cycle_rejects_invalid_output_columns() {
        let mut node = canonical_4cycle_multiway();
        if let RirNode::MultiWayJoin { output_columns, .. } = &mut node {
            *output_columns = vec![
                ProjectExpr::Column(1),
                ProjectExpr::Column(0),
                ProjectExpr::Column(3),
                ProjectExpr::Column(5),
            ];
        }
        assert!(match_multiway_4cycle(&node).is_none());
    }

    #[test]
    fn match_4cycle_rejects_arity_mismatched_output_columns() {
        let mut node = canonical_4cycle_multiway();
        if let RirNode::MultiWayJoin { output_columns, .. } = &mut node {
            output_columns.pop();
        }
        assert!(match_multiway_4cycle(&node).is_none());
    }

    #[test]
    fn match_4cycle_rejects_unclosed_cycle() {
        // Slot 3's second var is supposed to equal slot 0's first
        // var (closing the cycle). Replace with a fresh id.
        let mut node = canonical_4cycle_multiway();
        if let RirNode::MultiWayJoin { slot_vars, .. } = &mut node {
            slot_vars[3] = vec![Some(3), Some(99)];
        }
        assert!(match_multiway_4cycle(&node).is_none());
    }

    #[test]
    fn match_4cycle_rejects_non_scan_input() {
        let mut node = canonical_4cycle_multiway();
        if let RirNode::MultiWayJoin { inputs, .. } = &mut node {
            inputs[0] = RirNode::Unit;
        }
        assert!(match_multiway_4cycle(&node).is_none());
    }

    #[test]
    fn match_4cycle_rejects_input_arity_mismatch() {
        let mut node = canonical_4cycle_multiway();
        if let RirNode::MultiWayJoin { inputs, .. } = &mut node {
            inputs.push(RirNode::Scan { rel: RelId(5) });
        }
        assert!(match_multiway_4cycle(&node).is_none());
    }
}